GNOME Bugzilla – Bug 608267
Establish giggle as url-handler for git:// links
Last modified: 2012-03-07 13:27:42 UTC
When browsing repositories, it is nice to be able to click git:// URLs to create a clone. While this can be implemented with custom scripts, it would be a nice-to-have for giggle. Note that the UI patch assumes the patch to bug 608101 being applied. The progress bar shown during cloning will stop updating without the patch proposed in bug 608264, but there is no code dependency on that bug.
Created attachment 152422 [details] [review] Add helper method for removing a directory recursively Credit goes to Paolo Bacchilega, who wrote this code for file-roller.
Created attachment 152423 [details] [review] Implement clone command While this implementation does work, it is somehow limited by the current GitJob implementation - e.g. being a potentially time intensive operation, it would be nice to be able to pop up a good progress indicator in the interface.
Created attachment 152424 [details] [review] Add GiggleCloneDialog for clone operations GiggleCloneDialog implements a dialog for the clone command. It enables the user to enter the required parameters and perform the operation. If the operation is cancelled, files that have been cloned will be removed.
Created attachment 152425 [details] [review] Add UI and command line option for the clone command
Created attachment 152426 [details] [review] Establish giggle as url-handler for git:// URLs
Review of attachment 152423 [details] [review]: A little comment: Use a ->priv pointer instead of FOO_GET_PRIVATE all the time as you already done in giggle-clone-dialog
Created attachment 152871 [details] [review] Implement clone command Updated patch according to the review.
All the patches committed, sorry for the late review. Very cool new feature, BTW ;) Thanks Florian!
Comment on attachment 152422 [details] [review] Add helper method for removing a directory recursively cec4aeabe5d6ae24b25e992a7899ed233b3e1dcf
Comment on attachment 152424 [details] [review] Add GiggleCloneDialog for clone operations 38c10fd15f3216320c78b28d86c1c27bf1b17785
Comment on attachment 152425 [details] [review] Add UI and command line option for the clone command c873b0c98e5b04f18e6e4d4470f203d2851e531b
Comment on attachment 152426 [details] [review] Establish giggle as url-handler for git:// URLs b00dd6543014e32ab32918d9bf5e96107aca1c38
Comment on attachment 152871 [details] [review] Implement clone command 31627c2a8b8c09e5978e2f798faaafe729205a1d