Bug 608221 - Drag-and-drop of items downwards is off by one
Drag-and-drop of items downwards is off by one
Status: NEW
Product: alacarte
Classification: Applications
Component: general
0.12.x
Other Linux
: Normal minor
: ---
Assigned To: Alacarte Maintainer(s)
Alacarte Maintainer(s)
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2010-01-27 04:42 UTC by Mathieu Trudel-Lapierre
Modified: 2012-06-05 04:21 UTC (History)
2 users (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix off-by-one, menu item should be dropped where the line is when dragged downward. (624 bytes, patch)
2010-01-27 04:43 UTC, Mathieu Trudel-Lapierre 		reviewed Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Mathieu Trudel-Lapierre 2010-01-27 04:42:22 UTC 
As previously reported in 585807.

This bug still appears to be valid as of 0.12.4. I've attached a patch that seems to fix the issue. Thanks to Richard Liebscher for writing this patch.

[As reported on Launchpad here: https://bugs.edge.launchpad.net/alacarte/+bug/395692]
Comment 1 Mathieu Trudel-Lapierre 2010-01-27 04:43:13 UTC 
Created attachment 152376 [details] [review]
fix off-by-one, menu item should be dropped where the line is when dragged downward.
Comment 2 Christopher Halse Rogers 2010-11-25 04:24:25 UTC 
Review of attachment 152376 [details] [review]:

I'm not an Alacarte dev, but this patch fixes a real bug and looks sane.
Comment 3 André Klapper 2012-06-04 13:06:25 UTC 
jstpierre: Can you review the patch?
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-06-05 04:21:37 UTC 
DND has been removed. I'm going to rewrite it later this week if I get a chance.
Note You need to log in before you can comment on or make changes to this bug.