GNOME Bugzilla – Bug 608121
Build fail cause ifaddrs.h not available
Last modified: 2010-01-27 12:03:44 UTC
I'm building vinagre master and 2.29.6 code, both get following error: $ make [...] "vinagre-vnc-listener-dialog.c", line 24: cannot find include file: <ifaddrs.h> "../../vinagre/vinagre-utils.h", line 33: warning: enumerator value overflows INT_MAX (2147483647) "vinagre-vnc-listener-dialog.c", line 58: warning: implicit function declaration: getifaddrs "vinagre-vnc-listener-dialog.c", line 59: improper member use: ifa_next "vinagre-vnc-listener-dialog.c", line 59: warning: assignment type mismatch: pointer to struct ifaddrs {} "=" pointer to struct ifaddr {struct sockaddr {..} ifa_addr, union {..} ifa_ifu, pointer to struct ifnet {..} ifa_ifp, pointer to struct ifaddr {..} ifa_next} "vinagre-vnc-listener-dialog.c", line 61: improper member use: ifa_addr "vinagre-vnc-listener-dialog.c", line 61: operands have incompatible types: struct sockaddr {unsigned short sa_family, array[14] of char sa_data} "==" int "vinagre-vnc-listener-dialog.c", line 61: undefined struct/union member: ifa_name "vinagre-vnc-listener-dialog.c", line 61: undefined struct/union member: ifa_flags "vinagre-vnc-listener-dialog.c", line 61: improper member use: ifa_name "vinagre-vnc-listener-dialog.c", line 61: warning: improper pointer/integer combination: arg #1 "vinagre-vnc-listener-dialog.c", line 64: improper member use: ifa_addr "vinagre-vnc-listener-dialog.c", line 64: left operand of "->" must be pointer to struct/union "vinagre-vnc-listener-dialog.c", line 67: improper member use: ifa_addr "vinagre-vnc-listener-dialog.c", line 67: invalid cast expression "vinagre-vnc-listener-dialog.c", line 74: improper member use: ifa_addr "vinagre-vnc-listener-dialog.c", line 74: invalid cast expression "vinagre-vnc-listener-dialog.c", line 110: warning: implicit function declaration: freeifaddrs cc: acomp failed for vinagre-vnc-listener-dialog.c Solaris do have a bug to get ifaddrs.h but not now. http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6731945 vinagre code should be built if system does not have ifaddrs.h, I'd like to offer a patch later.
Created attachment 152284 [details] [review] user self ifaddrs.h if system do not have
Review of attachment 152284 [details] [review]: Hello, Halton. Just fix the check in configure.ac: AM_CONDITIONAL(SELF_IFADDRS, test "x$ac_cv_header_ifaddrs_h" != "xyes") And can commit. Thanks!
Committed in master 9674b327857d07aaf7b7d0595daba84ef4e9c57c
Hey, Halton, you didn't fix the check I told you... I just fixed that ;) http://git.gnome.org/browse/vinagre/commit/?id=5e4269b551ae50dd7d2ac598fe57c73ab61571da
(In reply to comment #4) > Hey, Halton, you didn't fix the check I told you... I just fixed that ;) > http://git.gnome.org/browse/vinagre/commit/?id=5e4269b551ae50dd7d2ac598fe57c73ab61571da Sorry, I did not notice the first "x" added. Thanks for the fixing.