After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608077 - doesn't report its sound capability when built with sound support
doesn't report its sound capability when built with sound support
Status: RESOLVED FIXED
Product: notification-daemon
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: William Jon McCann
Depends on:
Blocks:
 
 
Reported: 2010-01-25 21:07 UTC by William Jon McCann
Modified: 2010-06-24 04:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
report sound capability (6.40 KB, patch)
2010-01-25 21:08 UTC, William Jon McCann 		none Details | Review
real patch (820 bytes, patch)
2010-01-25 21:09 UTC, William Jon McCann 		none Details | Review
Clean up notify_daemon_get_capabilities() (1.48 KB, patch)
2010-06-24 01:47 UTC, Bastien Nocera 		none Details | Review
Advertise the "sound" capability (899 bytes, patch)
2010-06-24 01:47 UTC, Bastien Nocera 		none Details | Review

Description William Jon McCann 2010-01-25 21:07:39 UTC 
from http://trac.galago-project.org/ticket/187

"According to spec (http://www.galago-project.org/specs/notification/0.9/x408.html#command-get-capabilities) GetCapabilities? should have sound . But notification daemon misses it. I'll be attaching a patch to fix the issue."

Patch http://trac.galago-project.org/attachment/ticket/187/notification-daemon-0.4.0-report-sound-capability.patch
Comment 1 William Jon McCann 2010-01-25 21:08:25 UTC 
Created attachment 152257 [details] [review]
report sound capability
Comment 2 William Jon McCann 2010-01-25 21:09:38 UTC 
Created attachment 152258 [details] [review]
real patch
Comment 3 Bastien Nocera 2010-06-24 01:47:29 UTC 
Created attachment 164466 [details] [review]
Clean up notify_daemon_get_capabilities()

Using a GPtrArray, rather than incrementing by hand.
Comment 4 Bastien Nocera 2010-06-24 01:47:38 UTC 
Created attachment 164467 [details] [review]
Advertise the "sound" capability

As per specification.
Comment 5 William Jon McCann 2010-06-24 04:25:07 UTC 
Pushed.  Thanks.