After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608012 - Please drop the autostart .desktop file
Please drop the autostart .desktop file
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: Daemon
git master
Other Linux
: Normal normal
: 2.26.0
Assigned To: Martin Pitt
Seahorse Maintainer
Depends on: 608010
Blocks:
 
 
Reported: 2010-01-25 09:37 UTC by Martin Pitt
Modified: 2010-02-07 20:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
git formatted patch (2.45 KB, patch)
2010-01-25 09:59 UTC, Martin Pitt
none Details | Review

Description Martin Pitt 2010-01-25 09:37:43 UTC
seahorse-daemon should not have an autostart .desktop file:

 * The daemon is not even needed for the ssh and GPG agents, which are certainly the most common use cases. It is needed only for the nautilus plugin and the key manager application; for both of which a slightly increased startup time is bearable, since they do not get used very often.

 * The daemon costs quite a lot of startup time, almost one second of CPU on a Dell Mini 10 v netbook (see http://people.canonical.com/~pitti/bootcharts/daniel-lucid-20100122-1.png).

I dropped the autostart .desktop file locally, and verified that the ssh and gpg agents still work fine. One regression is that seahorse-preferences finds no key (due to seahorse-daemon crashing on d-bus activation, filed as bug 608010), and the other is the nautilus plugin not finding any keys (filed as 
https://launchpad.net/bugs/512233 for now, as a reminder for me; it might very well be due to the very same crash); I'll file a bug for it if it has a separate cause.

I'll send a patch for this once the two regressions are fixed.
Comment 1 Martin Pitt 2010-01-25 09:40:29 UTC
Oh, the bootchart actually has two "seahorse-daemon" (since it forks with an autostart file); so CPU usage is actually more like 1.5 to 2 seconds.
Comment 2 Martin Pitt 2010-01-25 09:47:52 UTC
For the record, once bug 608010 is fixed, the nautilus plugin correctly triggers seahorse-daemon and shows available keys, so the second bug mentioned (https://launchpad.net/bugs/512233) is just a duplicate.
Comment 3 Martin Pitt 2010-01-25 09:59:00 UTC
Created attachment 152209 [details] [review]
git formatted patch

This patch removes the daemon autostart file (details in git log in the patch).

What do you think about this?
Comment 4 Adam Schreiber 2010-02-07 20:27:15 UTC
Updated from libegg/smclient.  Thanks.
Comment 5 Adam Schreiber 2010-02-07 20:58:35 UTC
Thanks.  Tested and committed.