GNOME Bugzilla – Bug 607939
length of audio is faulty after 1 hour of continuous recording
Last modified: 2015-01-19 11:33:54 UTC
Created attachment 152153 [details] [review] fixes duration-reporting at 1 hour of continuous recording Hi, If you let gnome-sound-recorder record audio for exactly 1 hour, it reports: "0 minutes" as the "Length" (duration) of the audio recording. One second after this point it appears like this: "0 minutes, and 1 second". Please watch the attached video "before.ogv" to see the faulty behaviour in action on version 2.28.1 in Ubuntu's Karmic Koala. Clearly the intent is for the text to read "1 hour", and "1 hour and 1 second" respectively. See the attached file grecord-1-hour-duration-format.patch for a simple fix. It is applied against the latest version in the git repository, but the patch hasn't been created with git. I've also attached a video "after.ogv" that shows the program behaving properly with the patch installed. cheers, Ben
Created attachment 152154 [details] before.ogv: video of the bug in action
Created attachment 152155 [details] after.ogv: video of the same situation, but with the patch installed.
Review of attachment 152153 [details] [review]: ::: gsr-window.c.orig @@ +315,3 @@ if (seconds > 0) { + fmt = g_strdup_printf (_("%s and %s"), hourfmt, secondfmt); + /* Translators: the format is "X hours and X seconds" */ shouldn't it be hours & minutes instead?
No, check again. If you look outside of the patch into the context of the function, you'll see that it's in a minutes == 0 conditional block.
(In reply to comment #5) > No, check again. > If you look outside of the patch into the context of the function, you'll see > that it's in a minutes == 0 conditional block. right
Maybe this should be shared between Totem and gnome-media, or you could just copy the "totem_time_to_string_text()" function from src/backend/video-utils.c
(In reply to comment #7) > Maybe this should be shared between Totem and gnome-media, or you could just > copy the "totem_time_to_string_text()" function from src/backend/video-utils.c it was taken from rhythmbox, iirc :) should we propose it in glib?! g_{datetime}_to_human_string() ?
gnome-media has been obsolete since the release of GNOME 3, nearly 4 years ago. Furthermore, the gnome-sound-recorder program in gnome-media has been replaced by the stand-alone, rewritten, gnome-sound-recorder program which has a different interface. The new program should not be affected by the bugs you filed, however, please make sure to file new bugs against the gnome-sound-recorder product.