GNOME Bugzilla – Bug 607870
[oggdemux] OGM parsing broken
Last modified: 2010-01-24 07:58:08 UTC
Latest oggdemux changes broken ogm parsing. I'm working on it and have some patches locally already
Created attachment 152086 [details] [review] oggdemux: Store header/queued packets as ogg_packet and use normal peer chaining functions to pass them downstream
(In reply to comment #1) > Created an attachment (id=152086) [details] [review] > oggdemux: Store header/queued packets as ogg_packet and use normal peer > chaining functions to pass them downstream That's only a start, now ogm parsing needs to be fixed
commit a66ce94adcf337dfcc6c9c3845c1c2ad8a8d6d8f Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Sat Jan 23 22:09:45 2010 +0100 oggdemux: Correctly set DELTA_UNIT flag for OGM streams commit b38dcf5277f28e12b5b9bb1e554de78282ebb2f3 Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Sat Jan 23 22:05:40 2010 +0100 oggdemux: Don't strip all 0-bytes from the end of OGM packets This fixes broken packets pushed downstream by oggdemux for MPEG4 streams for example. commit 592bc87dc95d88e52fda9eec2d61828c2d6c6ec0 Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Sat Jan 23 22:03:18 2010 +0100 oggdemux: Extract tags from OGM text streams and don't push them downstream commit 541da50c538788f3bf5f5e03d8f4c031643aa71a Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Sat Jan 23 14:46:19 2010 +0100 oggdemux: Store header/queued packets as ogg_packet and use normal peer chai
Stripping zero bytes from the end of packets was intended for subtitle streams only. Oops. Example of why this is needed: http://samples.mplayerhq.hu/ogg/bgc.sub.dub.ogm
commit 1652005f266479821aa9905bc573e9477fc5acf1 Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Sun Jan 24 08:57:13 2010 +0100 oggdemux: Strip trailing \0 for subtitle OGM streams Fixes bug #607870.