After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 607870 - [oggdemux] OGM parsing broken
[oggdemux] OGM parsing broken
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.26
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-01-23 13:48 UTC by Sebastian Dröge (slomo)
Modified: 2010-01-24 07:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
oggdemux: Store header/queued packets as ogg_packet and use normal peer chaining functions to pass them downstream (4.45 KB, patch)
2010-01-23 13:52 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2010-01-23 13:48:02 UTC
Latest oggdemux changes broken ogm parsing. I'm working on it and have some patches locally already
Comment 1 Sebastian Dröge (slomo) 2010-01-23 13:52:24 UTC
Created attachment 152086 [details] [review]
oggdemux: Store header/queued packets as ogg_packet and use normal peer chaining functions to pass them downstream
Comment 2 Sebastian Dröge (slomo) 2010-01-23 13:53:26 UTC
(In reply to comment #1)
> Created an attachment (id=152086) [details] [review]
> oggdemux: Store header/queued packets as ogg_packet and use normal peer
> chaining functions to pass them downstream

That's only a start, now ogm parsing needs to be fixed
Comment 3 Sebastian Dröge (slomo) 2010-01-23 21:11:29 UTC
commit a66ce94adcf337dfcc6c9c3845c1c2ad8a8d6d8f
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Sat Jan 23 22:09:45 2010 +0100

    oggdemux: Correctly set DELTA_UNIT flag for OGM streams

commit b38dcf5277f28e12b5b9bb1e554de78282ebb2f3
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Sat Jan 23 22:05:40 2010 +0100

    oggdemux: Don't strip all 0-bytes from the end of OGM packets
    
    This fixes broken packets pushed downstream by oggdemux for
    MPEG4 streams for example.

commit 592bc87dc95d88e52fda9eec2d61828c2d6c6ec0
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Sat Jan 23 22:03:18 2010 +0100

    oggdemux: Extract tags from OGM text streams and don't push them downstream

commit 541da50c538788f3bf5f5e03d8f4c031643aa71a
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Sat Jan 23 14:46:19 2010 +0100

    oggdemux: Store header/queued packets as ogg_packet and use normal peer chai
Comment 4 David Schleef 2010-01-24 04:29:35 UTC
Stripping zero bytes from the end of packets was intended for subtitle streams only.  Oops.  Example of why this is needed:

http://samples.mplayerhq.hu/ogg/bgc.sub.dub.ogm
Comment 5 Sebastian Dröge (slomo) 2010-01-24 07:58:08 UTC
commit 1652005f266479821aa9905bc573e9477fc5acf1
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Sun Jan 24 08:57:13 2010 +0100

    oggdemux: Strip trailing \0 for subtitle OGM streams
    
    Fixes bug #607870.