After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 607839 - libpixbufloader-png.so not in library list
libpixbufloader-png.so not in library list
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
git master
Other All
: Normal minor
: ---
Assigned To: gtk-bugs
gtk-bugs
: 599774 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-01-23 03:52 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-07-10 04:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix warning (1.11 KB, patch)
2010-01-23 03:55 UTC, Javier Jardón (IRC: jjardon) 		reviewed Details | Review
Remove the definition of libpixbufloader_gdip_png_la_* (1.71 KB, patch)
2010-05-04 13:29 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-01-23 03:52:48 UTC 
The attached ptach fixes this warning:

gdk-pixbuf/Makefile.am:332: variable `libpixbufloader_gdip_png_la_SOURCES' is defined but no program or
gdk-pixbuf/Makefile.am:332: library has `libpixbufloader_gdip_png_la' as canonical name (possible typo)
Comment 1 Javier Jardón (IRC: jjardon) 2010-01-23 03:55:20 UTC 
Created attachment 152063 [details] [review]
Fix warning
Comment 2 Pablo Castellano (IRC: pablog) 2010-01-24 12:50:43 UTC 
*** Bug 599774 has been marked as a duplicate of this bug. ***
Comment 3 Pablo Castellano (IRC: pablog) 2010-01-24 12:52:01 UTC 
Review of attachment 152063 [details] [review]:

Tested and looks good for me.
Comment 4 Javier Jardón (IRC: jjardon) 2010-01-24 17:31:54 UTC 
Comment on attachment 152063 [details] [review]
Fix warning

Set to reviewed per Pablo comments
Comment 5 Javier Jardón (IRC: jjardon) 2010-02-06 21:41:43 UTC 
*** Bug 609185 has been marked as a duplicate of this bug. ***
Comment 6 Tor Lillqvist 2010-05-04 07:38:02 UTC 
Nah, libstatic-pixbufloader-gdip-png.la should not be built or at least not included in STATIC_GDIPLUS_LIBS as we don't want to use the GDI+-based loader for PNG, because if we do, we can't get (or was it set?) the options of a PNG pixbuf that for instance some code in GIMP wants to do.

I would just remove the definition of libpixbufloader_gdip_png_la_SOURCES (and _LDFLAGS and _LIBADD, presumably).
Comment 7 Javier Jardón (IRC: jjardon) 2010-05-04 13:29:01 UTC 
Created attachment 160259 [details] [review]
Remove the definition of libpixbufloader_gdip_png_la_*

Updated patch with your comments
Comment 8 Tor Lillqvist 2010-05-04 13:53:23 UTC 
Review of attachment 160259 [details] [review]:

Looks good to me
Comment 9 Javier Jardón (IRC: jjardon) 2010-05-04 14:14:34 UTC 
Comment on attachment 160259 [details] [review]
Remove the definition of libpixbufloader_gdip_png_la_*

master a141c3527165c5245aa6c4c57f73c8b9e125c223
gtk-2-22 501098e946869372ceb958e6493fc57d09b105e5
gtk-2-20 a6c4833d9a307a1905516fb497dfaf0f141e1c0d
Comment 10 Javier Jardón (IRC: jjardon) 2010-05-12 21:04:52 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.