After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 607747 - [dvbsrc] Pipeline does not stop when reception is very bad
[dvbsrc] Pipeline does not stop when reception is very bad
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-01-22 10:37 UTC by Vincent Génieux
Modified: 2010-01-27 11:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.59 KB, patch)
2010-01-22 10:44 UTC, Vincent Génieux 		none Details | Review
second proposed patch with unlock_stop function (2.60 KB, patch)
2010-01-26 16:37 UTC, Vincent Génieux 		committed Details | Review

Description Vincent Génieux 2010-01-22 10:37:01 UTC 
I cannot stop a pipeline when reception is very bad (ex: bad weather)

To reproduce the problem (use-case with a dvb-s card):

1) launch the following pipeline :    
   gst-launch dvbsrc frequency=12226000 polarity=H symbol-rate=27500 ! fakesink

2) Simulate a bad reception:
   unplug the dvb-s cable

3) stop the pipeline (CTRL+C)

result: pipeline does not stop.

expected: pipeline should stop, event if the dvb-s signal is not present.
Comment 1 Vincent Génieux 2010-01-22 10:44:39 UTC 
Created attachment 151997 [details] [review]
proposed patch

When the card is not locked (due to signal loss), there is an infinite loop into read_device function.

Proposed patch : 
 - use an flag to stop the loop when required
 - set the flag in the gst_dvb_src_unlock function.
Comment 2 Vincent Génieux 2010-01-26 16:37:33 UTC 
Created attachment 152321 [details] [review]
second proposed patch with unlock_stop function
Comment 3 Wim Taymans 2010-01-27 11:11:18 UTC 
commit 39ab05e02462634807fc59d36c45234d6b3319f6
Author: Vincent GENIEUX <vgenieux at free.fr>
Date:   Wed Jan 27 12:08:48 2010 +0100

    dvbsrc: fix element shutdown on bad reception
    
    When we have a bad reception, avoid going into an infinite loop by setting a
    shutdown flag when shutting down.
    
    Fixes #607747