After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 607738 - Should kill gnome-session rather than gnome-session process group when log in
Should kill gnome-session rather than gnome-session process group when log in
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.29.x
Other All
: Normal major
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on: 607658
Blocks:
 
 
Reported: 2010-01-22 09:10 UTC by Halton Huo
Modified: 2010-03-09 00:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not kill gnome-session process group when login. (1.01 KB, patch)
2010-01-22 09:19 UTC, Halton Huo 		committed Details | Review

Description Halton Huo 2010-01-22 09:10:49 UTC 
With fix for bug #607658, gnome-session is able to cleanup when receiving SIGTERM.

However, GDM kills gnome-session and its children at log in time.

gdm_welcome_session_stop()
[...]
        res = gdm_signal_pid (-1 * welcome_session->priv->pid, SIGTERM);
[...]

This will cause gnome-session's children quits before cleanup finish. So we should kill gnome-session only rather than its process group.
Comment 1 Halton Huo 2010-01-22 09:19:39 UTC 
Created attachment 151990 [details] [review]
Do not kill gnome-session process group when login.
Comment 2 Brian Cameron 2010-01-22 13:39:47 UTC 
Note that for this to work properly, gnome-session also needs to be modified to clean up its children on exit.  So I believe this fix depends on bug #607658, and that this fix should not go into GDM until that fix is accepted into gnome-session.  Isn't that correct, Halton?
Comment 3 Halton Huo 2010-01-22 21:49:54 UTC 
Brian, you're right the gnome-session should block this gdm bug. I'll change that. Note, Vicent has already accept the gnome-session patch.
Comment 4 Halton Huo 2010-01-29 04:02:25 UTC 
Patch for gnome-session bug #607658 is approved, not committed yet. Vincent want to make sure this patch make sense for GDM.

Brian and Ray, what's your opinion?
Comment 5 Ray Strode [halfline] 2010-03-08 21:16:33 UTC 
Yes, makes sense to me.
Comment 6 Brian Cameron 2010-03-08 21:26:57 UTC 
Looks good to me also.  Vincent, can we get the change for gnome-session into 2.30?  If so, let us know so we can coordinate making the change to GDM at the same time.
Comment 7 Brian Cameron 2010-03-09 00:19:18 UTC 
Worked with Vincent to get the fix into gnome-session for the 2.29.92 release, so this was fixed in GDM 2.29.92 as well.  Marking as fixed.