After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 607643 - AT_SPI_REGISTRYD_DIR is not substituted if at-spi-registryd-directory not given
AT_SPI_REGISTRYD_DIR is not substituted if at-spi-registryd-directory not given
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.29.x
Other All
: Normal major
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2010-01-21 10:08 UTC by Halton Huo
Modified: 2011-08-13 05:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for bug #607643 (1.09 KB, patch)
2010-01-21 10:17 UTC, Halton Huo
accepted-commit_now Details | Review

Description Halton Huo 2010-01-21 10:08:06 UTC
I'm building gdm master and gdm2.29.5 code under OpenSolaris and Ubuntu/Linux, I found AT_SPI_REGISTRYD_DIR in at-spi-registryd-wrapper.desktop is not substituted at all if --with-at-spi-registryd-directory is not given.

This bug is caused by following commit, I'll offer a fix later.

commit f2517f29eece3042b8babcfa6d7e234f74c8d63c
Author: Vincent Untz <vuntz@gnome.org>
Date:   Thu Dec 3 11:47:27 2009 +0100

    Fix desktop file for at-spi-registryd to use AT_SPI_REGISTRYD_DIR
    
    It's already defined in configure.ac.
Comment 1 Halton Huo 2010-01-21 10:17:44 UTC
Created attachment 151932 [details] [review]
patch for bug #607643
Comment 2 Halton Huo 2010-01-21 10:18:15 UTC
The above patch is verified under OpenSolaris and Linux/Ubuntu.
Comment 3 Brian Cameron 2010-01-27 16:29:01 UTC
Fixed in master.
Comment 4 Alexandre Rostovtsev 2011-08-13 05:14:31 UTC
This fix doesn't quite work.

@AT_SPI_REGISTRYD_DIR@ in at-spi-registryd-wrapper.desktop.in.in gets replaced with the *unexpanded* value of AT_SPI_REGISTRYD_DIR.

By default, libexecdir='${exec_prefix}/libexec'
By default, AT_SPI_REGISTRYD_DIR=${libexecdir}

Therefore, we end up with the following line in at-spi-registryd-wrapper.desktop:

Exec=${exec_prefix}/libexec/at-spi-registryd

which doesn't work because there is no directory literally called '${exec_prefix}' in the filesystem.