After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 607626 - buddy info tooltip should be prevented from showing if a popup menu is shown in the contact list
buddy info tooltip should be prevented from showing if a popup menu is shown ...
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Contact List
2.29.x
Other Linux
: Normal major
: ---
Assigned To: empathy-maint
: 612198 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-01-21 03:28 UTC by Jean-François Fortin Tam
Modified: 2010-03-08 16:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] Prevent contact list tooltip from showing if context menu is shown. (1016 bytes, patch)
2010-03-05 03:09 UTC, Mike Ruprecht
reviewed Details | Review
Updated per your review comments.\n (1.35 KB, patch)
2010-03-06 00:33 UTC, Mike Ruprecht
committed Details | Review

Description Jean-François Fortin Tam 2010-01-21 03:28:15 UTC
Two scenarios:
- right clicking someone in the contact list (brings up a menu)
- clicking on the webcam/audio icon (brings up a menu in 2.29.5)

The problem: the big tooltip that shows the user info when you mouse over the user is shown as long as the mouse is still over that user and not on the menu.

So when opening a menu, the contact list should not be able to display tooltips. They mask the menus you're trying to interact with. Major usability bug :)
Comment 1 Mike Ruprecht 2010-03-05 03:09:49 UTC
Created attachment 155279 [details] [review]
[PATCH] Prevent contact list tooltip from showing if context menu is shown.


Previously, if you opened a context menu in the contact list,
contact tooltips would still be capable of being shown and
obscuring the context menu options. This patch prevents tooltips
from being shown if a context menu is visible.

Fixes #607626
---
 libempathy-gtk/empathy-contact-list-view.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
Comment 2 Mike Ruprecht 2010-03-05 03:26:19 UTC
http://git.collabora.co.uk/?p=user/maiku/empathy.git;a=shortlog;h=refs/heads/bug-607626

Didn't pick the right git-send-bugzilla switch. Sorry.
Comment 3 Guillaume Desmottes 2010-03-05 09:08:30 UTC
Review of attachment 155279 [details] [review]:

This seems to work fine with the right click menu but not the audio/video one. Could you fix that too please?
Comment 4 Mike Ruprecht 2010-03-06 00:33:32 UTC
Created attachment 155393 [details] [review]
Updated per your review comments.\n

 libempathy-gtk/empathy-contact-list-view.c |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)
Comment 5 Guillaume Desmottes 2010-03-08 08:54:42 UTC
Looks good; merged to master. thanks !

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 6 Guillaume Desmottes 2010-03-08 16:34:46 UTC
*** Bug 612198 has been marked as a duplicate of this bug. ***