After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 607532 - Inheriting D-Bus interfaces from another file generates invalid C
Inheriting D-Bus interfaces from another file generates invalid C
Status: RESOLVED OBSOLETE
Product: vala
Classification: Core
Component: D-Bus
0.7.x
Other Linux
: Normal minor
: ---
Assigned To: Vala maintainers
Vala maintainers
wrong-code test-case
Depends on:
Blocks:
 
 
Reported: 2010-01-20 09:28 UTC by Evan Nemerson
Modified: 2010-10-13 22:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Test case (403 bytes, application/octet-stream)
2010-01-20 09:28 UTC, Evan Nemerson
  Details
Allows implementing DBus interfaces in different files (3.12 KB, patch)
2010-01-22 21:22 UTC, Marc-Andre Lureau
reviewed Details | Review

Description Evan Nemerson 2010-01-20 09:28:27 UTC
Created attachment 151820 [details]
Test case

Creating a D-Bus interface which requires a D-Bus interface from another file will generate invalid C. The attached test case will result in the following errors:

/home/nemequ/t/dbus-foo.vala.c: In function ‘foo_dbus_proxy_do_something’:
/home/nemequ/t/dbus-foo.vala.c:387: warning: incompatible implicit declaration of built-in function ‘strstr’
/home/nemequ/t/dbus-test.vala.c: In function ‘bar_dbus_proxy_do_something’:
/home/nemequ/t/dbus-test.vala.c:430: error: ‘FooDBusProxy’ undeclared (first use in this function)
/home/nemequ/t/dbus-test.vala.c:430: error: (Each undeclared identifier is reported only once
/home/nemequ/t/dbus-test.vala.c:430: error: for each function it appears in.)
/home/nemequ/t/dbus-test.vala.c:430: error: expected expression before ‘)’ token
error: cc exited with status 256
Compilation failed: 1 error(s), 0 warning(s)

Currently working around the issue by putting them in the same file.
Comment 1 Marc-Andre Lureau 2010-01-22 21:22:41 UTC
Created attachment 152042 [details] [review]
Allows implementing DBus interfaces in different files

Fixes bug 607532.
Comment 2 Jürg Billeter 2010-08-20 13:58:56 UTC
Comment on attachment 152042 [details] [review]
Allows implementing DBus interfaces in different files

The patch misses header declarations for the new is_disposed function in the case that the interface is public.

Do you want to finish the patch or drop it now that the focus is on GDBus anyway?
Comment 3 Jürg Billeter 2010-10-13 22:23:46 UTC
Resolving as obsolete as dbus-glib support is deprecated. Feel free to reopen it if someone is interested in contributing a finished patch.