GNOME Bugzilla – Bug 607427
XDS drop target priority
Last modified: 2013-08-02 14:20:40 UTC
I have an application which supports both uri-list and XDS as a drag source. The problem is that the uris are a custom protocol which is not related to file management (my application is a handler for those), but the XDS target is. I was wondering if it was possible to give priority of XDS over uris, or maybe to determine if nautilus can actually handle the uri, and if not fallback on other drop targets it supports.
Which nautilus version is this about? Is this an enhancement request?
I am facing a problem similar to Jesse. I too have a use case (bug 683316) where priority for XDS is desirable. It is there even in the latest nautilus. It's about GtkTargetEntry drop_types [], in nautilus-canvas-dnd.c . In the array, uri-list is mentioned before XDS, thus giving it more priority. Is there any specific reason why this has been done?
Created attachment 243408 [details] [review] Give XDS priority over text/uri-list This patch just gives priority to XDS over text/uri-list. I have submitted this based on following discussion on #nautilus - >[12:28am] aakash: hi, are any of the maintainers around? I had a question regarding https://bugzilla.gnome.org/show_bug.cgi?id=607427 >[12:28am] Services: Bug 607427: normal, Normal, ---, nautilus-maint, UNCONFIRMED, XDS drop target priority >[12:32am] cosimoc: aakash, hey I believe the reason for that is mostly historical, XDS is relatively recent >[12:33am] aakash: ok. So does it mean that XDS can be given higher priority (without breaking other applications, of course) in future releases of nautilus ? >[12:33am] You left the chat by being disconnected from the server. >[12:33am] You reconnected to the server. >[12:33am] You rejoined the room. >[12:33am] cosimoc: aakash_, did you see my messages? >[12:33am] aakash_: no >[12:33am] aakash_: did you get this one-> ok. So does it mean that XDS can be given higher priority (without breaking other applications, of course) in future releases of nautilus ? >[12:33am] cosimoc: <cosimoc> aakash, hey I believe the reason for that is mostly historical, XDS is relatively recent >[12:33am] cosimoc: <cosimoc> aakash, so you want nautilus to basically accept the XDS instead of the URIs when both are available? >[12:34am] aakash_: yes. >[12:34am] aakash_: that would be right >[12:34am] cosimoc: sounds reasonable to me >[12:35am] aakash_: that would help me in a patch I am making for evince https://bugzilla.gnome.org/show_bug.cgi?id=683316. >[12:35am] Services: Bug 683316: normal, Normal, ---, evince-maint, UNCONFIRMED, Drag and Drop of attachment adds random characters >[12:35am] cosimoc: aakash_, feel free to come up with a patch - I don't really see how that could break existing applications >[12:36am] aakash_: and I guess it would also help others, as mentioned in https://bugzilla.gnome.org/show_bug.cgi?id=607427 >[12:36am] Services: Bug 607427: normal, Normal, ---, nautilus-maint, UNCONFIRMED, XDS drop target priority >[12:36am] aakash_: I guess I'll submit a patch for this then. >[12:36am] cosimoc: cool, thanks >[12:37am] aakash_: thank you too !
Looks good, pushed to master