GNOME Bugzilla – Bug 607403
rtpaudiopayload: ptime is in milli-seconds, convert to nanosecs
Last modified: 2010-01-21 09:56:53 UTC
The ptime is stored in ms, it must be converted to ns for rtpbaseaudiopaylod to work. That said, maybe I'm wrong and it should be stored in NS in rtpbasepayload. Also, second question, right now ptime and maxptime are of type "int" in the caps, maybe they should be "uint" instead...
Created attachment 151732 [details] [review] rtpaudiopayload: ptime is in milli-seconds, convert to nanosecs
It should be stored in ns, like all other ptime values IMO.
ouch, it is in ms, documented in the .h file and of guint size.. Guess we need to keep it ms then.
Well, its not released, so I guess we can still change it...
Created attachment 151780 [details] [review] basertppayload: ptime should be in nanoseconds
Created attachment 151781 [details] [review] basertppayload: ptime/maxptime should be unsigned
Created attachment 151782 [details] [review] rtpg729pay: ptime should is in nanoseconds
commit 6c6d0e32cf227a8396c0299c1786e228fa27ea1d Author: Olivier Crête <olivier.crete@collabora.co.uk> Date: Tue Jan 19 14:31:34 2010 -0500 basertppayload: ptime/maxptime should be unsigned https://bugzilla.gnome.org/show_bug.cgi?id=607403 commit 8d2ac0b2ec386ede0e29a174b102574020072dcd Author: Olivier Crête <olivier.crete@collabora.co.uk> Date: Mon Jan 18 21:16:32 2010 -0500 basertppayload: ptime should be in nanoseconds https://bugzilla.gnome.org/show_bug.cgi?id=607403
commit 9afc247906dd6c785178f10e1ec91ba825621c63 Author: Olivier Crête <olivier.crete@collabora.co.uk> Date: Mon Jan 18 21:15:51 2010 -0500 rtpg729pay: ptime should is in nanoseconds https://bugzilla.gnome.org/show_bug.cgi?id=607403