After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 607398 - Do not use CGL_* symbols
Do not use CGL_* symbols
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2010-01-19 01:34 UTC by Emmanuele Bassi (:ebassi)
Modified: 2010-01-19 21:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not use CGL_* symbols (4.52 KB, patch)
2010-01-19 01:34 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review

Description Emmanuele Bassi (:ebassi) 2010-01-19 01:34:21 UTC 
Mutter is using CGL_* symbols in mutter-shaped-texture.c and mutter-texture-tower.c

The CGL_* symbols have always been considered private and should have never been used by application code. The fact that sometimes they were deemed necessary was a bug that has been rectified by Clutter 1.1.

Since the 1.1.6 developers snapshot, Clutter does not export those defines any more, and thus Mutter's compilation fails.
Comment 1 Emmanuele Bassi (:ebassi) 2010-01-19 01:34:23 UTC 
Created attachment 151728 [details] [review]
Do not use CGL_* symbols

The CGL_* defines in COGL were always meant to be private and should
have never been exposed in the first place. The API in COGL has been
updated to never require them starting from 1.1, but using the original
GL symbols has always been the intent of the API.

This commit removes the CGL_TEXTURE_RECTANGLE_ARB usage in favour of the
ARB-sanctioned GL_TEXTURE_RECTANGLE_ARB enumeration value.

Signed-off-by: Emmanuele Bassi <ebassi@linux.intel.com>
Comment 2 Colin Walters 2010-01-19 21:29:38 UTC 
Review of attachment 151728 [details] [review]:

Sounds good to me.
Comment 3 Emmanuele Bassi (:ebassi) 2010-01-19 21:57:39 UTC 
Attachment 151728 [details] pushed as 2fbe4c2 - Do not use CGL_* symbols