After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 607348 - Poperties for GtkAction and GtkTreeViewColumn not marked as translatable in catalog
Poperties for GtkAction and GtkTreeViewColumn not marked as translatable in c...
Status: RESOLVED FIXED
Product: glade
Classification: Applications
Component: general
git master
Other Linux
: Normal minor
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-01-18 19:35 UTC by J. Félix Ontañón
Modified: 2010-04-01 17:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Mark some properties as translatable for GtkTreeViewColumn and GtkAction in gtk+ catalog (1.51 KB, patch)
2010-01-18 19:48 UTC, J. Félix Ontañón
none Details | Review
Mark several properties as translatable in GtkAction, GtkTreeViewColumn and GtkStatusIcon (1.39 KB, patch)
2010-01-19 20:13 UTC, Johannes H. Jensen
none Details | Review

Description J. Félix Ontañón 2010-01-18 19:35:31 UTC
Some properties are not marked as translatable in gtk+.xml catalog for GtkAction and GtkTreeViewColumn, and so for that, Glade doesn't allow the user mark them as translatable, or write the translation context and comments for translators:

GtkAction: label, short-label, tooltip
GtkTreeViewColumn: title

Related bug: https://bugzilla.gnome.org/show_bug.cgi?id=590654

Affects, at least, versions "git master" and 3.6.x
Comment 1 J. Félix Ontañón 2010-01-18 19:48:39 UTC
Created attachment 151698 [details] [review]
Mark some properties as translatable for GtkTreeViewColumn and GtkAction in gtk+ catalog

Patch from git master version
Comment 2 J. Félix Ontañón 2010-01-18 19:49:46 UTC
Patch generated with: git format-patch -1
Comment 3 J. Félix Ontañón 2010-01-18 19:54:51 UTC
I can confirm it also mark as translatable the [label, short-label, tooltip] properties for GtkToggleAction, GtkRadioAction and GtkRecentAction as their inherited from GtkAction.
Comment 4 Johannes H. Jensen 2010-01-19 20:13:07 UTC
Created attachment 151785 [details] [review]
Mark several properties as translatable in GtkAction, GtkTreeViewColumn and GtkStatusIcon

GtkStatusIcon title, tooltip-markup and tooltip-text are not marked as translatable either. Updated patch. Please test.
Comment 5 J. Félix Ontañón 2010-01-19 21:01:22 UTC
I can confirm for Glade-3.6.7 the bug and solution. For GtkStatusIcon "title" property i can see in Glade the "only for 2.18" warning too.

Johannes, do you know the "since" attribute for the properties reported in GtkAction and GtkTreeViewColumn? How can i find them out?
Comment 6 Johannes H. Jensen 2010-01-19 21:43:26 UTC
(In reply to comment #5)
> I can confirm for Glade-3.6.7 the bug and solution. For GtkStatusIcon "title"
> property i can see in Glade the "only for 2.18" warning too.
> 
> Johannes, do you know the "since" attribute for the properties reported in
> GtkAction and GtkTreeViewColumn? How can i find them out?

I'm not sure I'm using the "since" attribute correctly, but you can find in which version of gtk+ each attribute was added in the widget docs:

http://library.gnome.org/devel/gtk/unstable/GtkAction.html
http://library.gnome.org/devel/gtk/unstable/GtkTreeViewColumn.html

If the properties in question do not have a "Since 2.xx" note, I'd ignore the since attribute. But again, I'm not quite sure how it should be used in the glade catalog :-)
Comment 7 Tristan Van Berkom 2010-04-01 17:33:58 UTC
I've recently updated the catalog for 2.20, these strings are translatable now.