After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 607146 - hitting enter on creating an account should "log in"
hitting enter on creating an account should "log in"
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
2.29.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-01-16 15:31 UTC by Felix Kaser
Modified: 2010-11-15 15:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make <enter> try to log in (2.03 KB, patch)
2010-11-15 13:56 UTC, Emilio Pozuelo Monfort 		committed Details | Review

Description Felix Kaser 2010-01-16 15:31:35 UTC 
when I fill in the details of a new account I expect that when I hit enter after filling in the details that the log-in button is triggered.

this should be easy to fix I guess...

the enter key should trigger the log in when the current focus is on password and on username as well (because if I filled in the details and switch protocoll, see #605532, the focus is on the username field).
Comment 1 Emilio Pozuelo Monfort 2010-11-15 13:56:16 UTC 
Created attachment 174508 [details] [review]
Make <enter> try to log in

I've fixed this bug on this branch:

http://git.collabora.co.uk/?p=user/pochu/empathy.git;a=shortlog;h=refs/heads/bug-607146

Please review :)
Comment 2 Guillaume Desmottes 2010-11-15 14:45:59 UTC 
Review of attachment 174508 [details] [review]:

Looks good. Please merge to master.
Comment 3 Emilio Pozuelo Monfort 2010-11-15 15:06:59 UTC 
This problem has been fixed in the development version. The fix will be
available in the next major software release. Thank you for your bug report.