GNOME Bugzilla – Bug 607082
Add accessors for sealed GtkRange members
Last modified: 2011-02-04 16:12:22 UTC
In order to properly subclass GtkRange, we need a lot of accessors, will attach patches.
Created attachment 151479 [details] [review] Accessors needed to implement GimpColorScale AFAICS, the only missing thing now is accessors for range->has_stepper_a,b,c,d, which are clearly needed by other subclasses out there.
Looks fine to me.
Review of attachment 151479 [details] [review]: Did we decide against making such only-for-subclassing things properties ? Unless we did, it looks slightly odd to add all these getters and setters without the properties themselves.
I don't know if we decided anything, but in this particular case I don't see much use for changing the two added "properties" at all after object creation, let alone having notification on them.
Ok then, go ahead.
Committed: commit 35a2b6532854251f5aed2eba22549f12154a805e Author: Michael Natterer <mitch@gimp.org> Date: Fri Jan 22 16:52:56 2010 +0100 Bug 607082 - Add accessors for sealed GtkRange members Add accessors for range->range_rect, range->slider_range, range->slider_size_fixed and range->min_slider_size. Didn't add properties for any of them because thir purpose is mostly to enable proper subclassing. gtk/gtk.symbols | 6 ++ gtk/gtkrange.c | 149 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ gtk/gtkrange.h | 14 +++++ 3 files changed, 169 insertions(+), 0 deletions(-) Not closing as FIXED because there is still stuff to do in GtkRange.
Mitch: What is the remaining work in GtkRange?
To be honest, I don't remember :) Just get rid of the bug.
Closing then ;)