GNOME Bugzilla – Bug 606987
Support for application-indicators/StatusNotifierIcon
Last modified: 2012-11-20 00:20:10 UTC
We would like to support application-indicators for Nautilus as proposed at this page and on GNOME d-d-l: https://wiki.ubuntu.com/DesktopExperienceTeam/ApplicationIndicators The Canonical DX team will provide a patch for this enhancement.
Created attachment 152026 [details] [review] change to use the application indicator The patch is used on ubuntu lucid now, it adds a build-time option. The build without the indicator has no change compared to what is used now. The libindicate library does handle the case where not indicator applet is present and does a fallback to use a notification area icon in such cases too.
Review of attachment 152026 [details] [review]: Sorry for taking so long to review this. Is this still something Ubuntu uses with Unity and wants to upstream? Assuming so, patch looks mostly fine; here are some comments. ::: nautilus-2.29.1.orig/configure.in @@ +310,3 @@ + ] + msg_appindicator=yes, + [AM_CONDITIONAL(HAVE_APP_INDICATOR, 0) This should be [AM_CONDITIONAL(HAVE_APP_INDICATOR, false) ::: nautilus-2.29.1.orig/libnautilus-private/Makefile.am @@ +11,3 @@ $(TRACKER_CFLAGS) \ $(BEAGLE_CFLAGS) \ + $(APP_INDICATOR_CFLAGS) \ Not sure this hunk still applies, as I clanged the CFLAGS/LIBS organization in configure.in some time ago. ::: nautilus-2.29.1.orig/libnautilus-private/Makefile.in @@ +258,3 @@ AM_DEFAULT_VERBOSITY = @AM_DEFAULT_VERBOSITY@ +APP_INDICATOR_CFLAGS = @APP_INDICATOR_CFLAGS@ +APP_INDICATOR_LIBS = @APP_INDICATOR_LIBS@ Makefile.in files are not tracked in git ::: nautilus-2.29.1.orig/config.h.in @@ +51,3 @@ +/* Have AppIndicator */ +#undef HAVE_APP_INDICATOR + config.h.in is not tracked in git
Closing as WONTFIX, as indicators never got adopted upstream (and there was no feedback following the review).