After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 606793 - Don't disable the tap-to-click checkbox for single-button touchpads
Don't disable the tap-to-click checkbox for single-button touchpads
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Mouse
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on: 606794
Blocks:
 
 
Reported: 2010-01-12 23:19 UTC by Peter Hutterer
Modified: 2010-01-16 10:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-Disable-tapping-only-for-touchpads-without-a-left-mo.patch (1.34 KB, patch)
2010-01-12 23:52 UTC, Peter Hutterer
committed Details | Review

Description Peter Hutterer 2010-01-12 23:19:26 UTC
a5bf115175ea52c5cdc184b3844d06bdb7ad775c sets the sensitivity of the tap-to-click checkbox based on the capabilities settings. The idea behind it was that users shouldn't be able to disable tapping if they don't have physical buttons to re-enable this setting.

With commit a5bf11 the condition for this was if a touchpad is lacking any physical button. There's a type of touchpads that only have a single button and for those tapping cannot be disabled.

See Fedora bug https://bugzilla.redhat.com/show_bug.cgi?id=548978.

For these touchpads (and I guess generally) the condition should be to check if the touchpad doesn't have a left mouse button, i.e. a diff of something like this:

- if (!data[0] || !data[1] || !data[2]) {
+ if (!data[0]) {
Comment 1 Peter Hutterer 2010-01-12 23:52:54 UTC
Created attachment 151296 [details] [review]
0001-Disable-tapping-only-for-touchpads-without-a-left-mo.patch