After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 606780 - Non-static async obj.method.end() doesn't work
Non-static async obj.method.end() doesn't work
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Async
0.7.x
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2010-01-12 20:53 UTC by Luca Bruno
Modified: 2010-01-16 18:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
vala test case (183 bytes, application/octet-stream)
2010-01-12 20:53 UTC, Luca Bruno
  Details
fix inner instance for .end (1.04 KB, patch)
2010-01-12 21:31 UTC, Luca Bruno
none Details | Review

Description Luca Bruno 2010-01-12 20:53:17 UTC
Created attachment 151287 [details]
vala test case

Hello,
I've attached a test case where the generated C code is wrong.
Generated code is:
_tmp0_ = test_test_finish ((Test*) test_test, r);

While it should be something like:
_tmp0_ = test_test_finish ((Test*) s, r);
Comment 1 Luca Bruno 2010-01-12 21:31:40 UTC
Created attachment 151291 [details] [review]
fix inner instance for .end

This is the first time I look "a bit" more deeply in your code, it's huge, I hope this is the right patch.
I don't know whether the ("begin" || "end") syntax satisfies your coding guidelines (looks like not from the other code).
Comment 2 Jürg Billeter 2010-01-16 18:18:39 UTC
commit 3c3815343f2cee6828c5010f5dd2d1eb54477fc8
Author: Luca Bruno <lethalman88@gmail.com>
Date:   Tue Jan 12 22:28:12 2010 +0100

    GAsync: Fix .end instance argument
    
    Fixes bug 606780.