After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 606717 - #if !defined(X) broken in doxygen 1.6.2
#if !defined(X) broken in doxygen 1.6.2
Status: RESOLVED FIXED
Product: doxygen
Classification: Other
Component: general
1.6.2
Other Linux
: Normal major
: ---
Assigned To: Dimitri van Heesch
Dimitri van Heesch
Depends on:
Blocks:
 
 
Reported: 2010-01-12 08:58 UTC by Matthias Klose
Modified: 2010-02-21 12:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
This patch works for me (1.02 KB, patch)
2010-02-02 11:45 UTC, Mattias Ellert 		none Details | Review

Description Matthias Klose 2010-01-12 08:58:25 UTC 
[forwarded from http://bugs.debian.org/564703]

There is a bug in doxygen version 1.6.2 where

#if !defined(X)

is not equivalent to

#ifndef X

I managed to build one of my FTBFS packages with doxygen 1.6.2 if I
changed all the multiple inclusion checks at the top of the header files
that used the first form to use the second form instead.
Comment 1 Dimitri van Heesch 2010-01-23 19:58:25 UTC 
Confirmed. Should be fixed in the next subversion update.
Comment 2 Mattias Ellert 2010-01-25 15:44:26 UTC 
I have tested it with the doxygen-1.6.2-20100124 svn tag.

It is better but not yet OK.

The following now works:

#if !defined(X)
#define X
...
#endif

But the following, which should give the same result does not:

#if !defined(X)
#define X 1
...
#endif
Comment 3 Mattias Ellert 2010-02-02 11:45:43 UTC 
Created attachment 152825 [details] [review]
This patch works for me

The attached patch (against the 20100124 svn tag) fixes the issue for my use case.
Comment 4 Mattias Ellert 2010-02-08 11:39:44 UTC 
Any chance there could be a new release soon that fixes this serious regression?
Comment 5 Mattias Ellert 2010-02-08 22:18:41 UTC 
I have now tested with the doxygen-1.6.2-20100208 svn tag. I confirm that the problem is fixed in this tag.
Comment 6 Dimitri van Heesch 2010-02-21 12:57:29 UTC 
This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.6.3. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information 
that you think can be relevant.