Bug 606456 – crashes in pixbuf_draw_gradient

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 606456 - crashes in pixbuf_draw_gradient


Summary:	crashes in pixbuf_draw_gradient


Status:	RESOLVED FIXED

Product:	gnome-desktop
Classification:	Core
Component:	libgnome-desktop
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Desktop Maintainers
QA Contact:	Desktop Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2010-01-08 22:32 UTC by Matthias Clasen
Modified:	2010-03-16 14:25 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
a patch (15.69 KB, patch) 2010-01-08 22:32 UTC, Matthias Clasen	committed	Details \| Review

Description Matthias Clasen 2010-01-08 22:32:32 UTC

Created attachment 151069 [details] [review]
a patch

Since the latest multi-monitor background changes have landed, we are seeing occasional gnome-settings-daemon crashes, e.g

https://bugzilla.redhat.com/show_bug.cgi?id=552368

I think what is happening here is that pixbuf_draw_gradient is getting called with a rectangle thats not contained in the pixbuf extents.

Comment 1 Vincent Untz 2010-03-08 15:34:30 UTC

Was committed by Jon already.

Comment 2 Ray Strode [halfline] 2010-03-08 15:38:40 UTC

Comment on attachment 151069 [details] [review]
a patch

This was commited already:
http://git.gnome.org/browse/gnome-desktop/commit/?id=5a080e8f12ed6da1b1d1df545d15870742b99c2b

Comment 3 Sebastien Bacher 2010-03-09 21:45:00 UTC

The fixes seems to not be working, there is a similar crash using gnome-desktop 2.29.90 on https://bugs.launchpad.net/gnome-settings-daemon/+bug/522639

"#0  0x00007f1fda6640c4 in pixbuf_draw_gradient (pixbuf=<value optimized out>, 
    horizontal=0, primary=<value optimized out>, 
    secondary=<value optimized out>, rect=<value optimized out>)
    at gnome-bg.c:2422
	d = (guchar *) 0x7f1fd1657000 <Address 0x7f1fd1657000 out of bounds>
	gradient = (
    guchar *) 0x19ed9b0 "ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h@ï¿½h"...
	width = 1920
	height = <value optimized out>
	rowstride = <value optimized out>
	dst = <value optimized out>

+ Trace 220889

#1 gnome_bg_draw
at gnome-bg.c line 765
#2 gnome_bg_create_pixmap
at gnome-bg.c line 1075
#3 draw_background
at gsd-background-manager.c line 189
#4 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#5 ??
from /usr/lib/libgobject-2.0.so.0
#6 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#7 g_signal_emit_by_name
from /usr/lib/libgobject-2.0.so.0
#8 _gdk_x11_screen_size_changed
at /build/buildd/gtk+2.0-2.19.5/gdk/x11/gdkscreen-x11.c line 1130
#9 gdk_event_translate
at /build/buildd/gtk+2.0-2.19.5/gdk/x11/gdkevents-x11.c line 2121
#10 _gdk_events_queue
at /build/buildd/gtk+2.0-2.19.5/gdk/x11/gdkevents-x11.c line 2305
#11 gdk_event_dispatch
at /build/buildd/gtk+2.0-2.19.5/gdk/x11/gdkevents-x11.c line 2366
#12 g_main_context_dispatch
from /lib/libglib-2.0.so.0
#13 ??
from /lib/libglib-2.0.so.0
#14 g_main_loop_run
from /lib/libglib-2.0.so.0
#15 IA__gtk_main
at /build/buildd/gtk+2.0-2.19.5/gtk/gtkmain.c line 1219
#16 main
at main.c line 502


Note that fedora still seems to have a patch for this issue: http://cvs.fedoraproject.org/viewvc/devel/gnome-desktop/gnome-desktop-crash.patch?view=log

Comment 4 Ray Strode [halfline] 2010-03-16 14:25:22 UTC

that one's commited now too.