After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 606374 - Use external files for theme
Use external files for theme
Product: quadrapassel
Classification: Applications
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: quadrapassel-maint
Depends on:
Reported: 2010-01-08 04:14 UTC by Mark Curtis
Modified: 2018-05-22 12:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Description Mark Curtis 2010-01-08 04:14:23 UTC
I first filed this bug about the default theme in Quadrapassel

I figured I'd take it a step further and make my own theme.  I looked at /usr/share/gnome-games/quadrapassel/pixmaps and found a few files

quadrapassel.svg which is the background
I then saw 7-blocks-gw.png and 7-blocks-tig.png which looked nothing like the included themes of "Flat" "Tango" and "Tango Shaded".

Scouring through the source I believe I found that the themes are hard coded

The fact that the line of code is prefaced with 
"/* the following garbage is derived from the official tango style guide */"
Wouldn't it make sense to code Quadrapassel (and other gnome-games) to use svg and/or png files rather than be hard coded with "garbage"?

I see while Mahjongg has a set of svgs for its tiles, the cards for Aislerot are no where to be found.
Mines has svgs, but the aforementioned Quadrapassel does not.

I haven't checked all gnome-games but those few already illustrate my point
It's also a matter of consistency across gnome-games.
Comment 1 Christian Persch 2010-01-08 11:40:28 UTC
(Aisleriot IS themeable. The default aisleriot cards are in libgames-support/ dir, while the extra cards are in gnome-games-extra-data git module).
Comment 2 Mark Curtis 2010-01-23 21:31:36 UTC
Okay Aisleriot is themeable it's just not in /usr/share/gnome-games/{game} like all the others.

I downloaded all the games, seems the themes for the most part are in /usr/share/gnome-games/{gamename}/pixmaps, with the exception of Lights Off ans Swell Foop which are in /usr/share/gnome-games/{gamename}/themes and Robots which uses both folders.

While it would be nice to have a consistent folder for all the games, the main point of this bug is to make all the games themeable.  While I haven't tried all of them yet, it appears Quadrapassel (the game this bug is filed under) is the ONLY game where it isn't possible to theme is merely by replacing svgs.
Comment 3 Robert Ancell 2012-02-06 08:39:53 UTC
Update description - the themes are currently hard-coded but could be easily done using .svg files that can be overridden.
Comment 4 GNOME Infrastructure Team 2018-05-22 12:28:15 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: