After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 606371 - mpegdemux2 plugin doesn't work on some ARM CPU due to the guint32*'s alignment
mpegdemux2 plugin doesn't work on some ARM CPU due to the guint32*'s alignment
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-01-08 02:54 UTC by pulq.ustc
Modified: 2010-02-09 09:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
bug fix for #606371 (632 bytes, patch)
2010-01-08 03:09 UTC, pulq.ustc 		none Details | Review

Description pulq.ustc 2010-01-08 02:54:32 UTC 
guint32* address is required to align to int boundary, which will be 4x. Can't get a correct int value with address offset 1,2,3.

I modified the original gstmpegdemux.c ( 
http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst/mpegdemux/gstmpegdemux.c) by replacing:
"GUINT32_FROM_BE (*(guint32 *) data)" --> "GST_READ_UINT32_BE(data)" 
"GUINT32_FROM_BE (*(guint32 *) (data + 4))" ---> GST_READ_UINT32_BE((data + 4))

And it works well.
Comment 1 pulq.ustc 2010-01-08 03:09:15 UTC 
Created attachment 151017 [details] [review]
bug fix for #606371
Comment 2 Thiago Sousa Santos 2010-01-08 12:39:08 UTC 
Could you provide your real name for adding to the commit logs?
Comment 3 pulq.ustc 2010-01-09 01:33:16 UTC 
(In reply to comment #2)
> Could you provide your real name for adding to the commit logs?

Hi Thiago, my real name is Linqiang Pu.
Thanks!
Comment 4 Thiago Sousa Santos 2010-01-10 13:12:11 UTC 
Fixed, thanks.

Module: gst-plugins-bad
Branch: master
Commit: d68c2d4ab93fca79d0d1a1ebadde91176359c7ed
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=d68c2d4ab93fca79d0d1a1ebadde91176359c7ed

Author: Linqiang Pu <pulq.ustc@gmail.com>
Date:   Sun Jan 10 10:06:55 2010 -0300

mpegdemux: fix allignment issue

Use GST_READ_UINT32_BE instead of GUINT32_FROM_BE to
fix int allignment issues on ARM

Fixes #606371