After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 606324 - Drop trailing slashes from two definitions
Drop trailing slashes from two definitions
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: daemon
1.5.x
Other Linux
: Normal minor
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2010-01-07 16:42 UTC by Paul Bolle
Modified: 2013-10-25 04:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
trivial patch; tested againt gvfs-1.5.1 (674 bytes, patch)
2010-01-07 16:46 UTC, Paul Bolle 		none Details | Review
Remove unnecessary trailing slashes in path (853 bytes, patch)
2013-10-17 17:06 UTC, Ross Lagerwall 		accepted-commit_now Details | Review

Description Paul Bolle 2010-01-07 16:42:10 UTC 
0) "ps aux" showed this process:
    $USER       1680  0.0  0.1  38756  2424 ?        Ssl  11:49   0:00 /usr/libexec//gvfs-fuse-daemon /home/$USER/.gvfs

Note the double slash.

1) Turns out this is caused by this macro definition in daemon/Makefile.am:
    -DLIBEXEC_DIR=\"$(libexecdir)/\"

2) A trivial patch to remove that trailing slash (and another unneeded trailing slash, that is only used in functions that also accept paths to directories without a trailing slash) is to be attached shortly.
Comment 1 Paul Bolle 2010-01-07 16:46:48 UTC 
Created attachment 150981 [details] [review]
trivial patch; tested againt gvfs-1.5.1
Comment 2 Ross Lagerwall 2013-10-17 17:06:55 UTC 
Created attachment 257563 [details] [review]
Remove unnecessary trailing slashes in path
Comment 3 Ross Lagerwall 2013-10-17 17:07:50 UTC 
I refreshed the patch so that it compiles cleanly against the git master.
Comment 4 Ondrej Holy 2013-10-24 14:22:28 UTC 
Review of attachment 257563 [details] [review]:

It looks good.
Comment 5 Ross Lagerwall 2013-10-25 04:31:42 UTC 
Pushed to master as e7470c3.