GNOME Bugzilla – Bug 606098
Epiphany prints "Blank page" in the title when opening a new tab
Last modified: 2010-02-10 16:41:15 UTC
Use middle button to open a link in a new tab, the tab title shows "Blank page" instead of the loading message "Loading... <url>". It seems the problem is the status of the page loading and the title used are not correctly synchronized.
Created attachment 150838 [details] [review] Proposed patch This patch fixes the problem, now the ephy_web_view_get_title_composite always returns the loading title when loading and the title after that if it is not blank. I've also modified the tabs title to use ephy_web_view_get_title_composite instead of ephy_web_view_get_title.
Review of attachment 150838 [details] [review]: ::: embed/ephy-web-view.c @@ +3194,2 @@ } title = _("Blank page"); This logic has been unchanged since some time, so it seems weird that it would fail now. If the tab title is "Blank page" it means is_loading is FALSE, which should not be the case. Guess you should look into that? ::: src/ephy-notebook.c @@ +539,2 @@ const char *title; + title = ephy_web_view_get_title_composite (view); I agree with this as long as the only change is to print "Loading ..." when the title is not know (like Firefox does). Otherwise having [Spinner] Loading ... DOMAIN.com would be too much clutter IMHO.
(In reply to comment #2) > Review of attachment 150838 [details] [review]: > > ::: embed/ephy-web-view.c > @@ +3194,2 @@ > } > title = _("Blank page"); > > This logic has been unchanged since some time, so it seems weird that it would > fail now. If the tab title is "Blank page" it means is_loading is FALSE, which > should not be the case. Guess you should look into that? > Right, the problem with the patch I sent is that it discards the title even when we really have it until we finish loading. There is an specific webkit method to point out we have received the title dispatchDidReceiveTitle probably because it does not match with any other state, so set_address or loading are not the best options. Maybe we can check if title_changed_cb was dispatched and set a variable to TRUE. > ::: src/ephy-notebook.c > @@ +539,2 @@ > const char *title; > + title = ephy_web_view_get_title_composite (view); > > I agree with this as long as the only change is to print "Loading ..." when the > title is not know (like Firefox does). Otherwise having [Spinner] Loading ... > DOMAIN.com would be too much clutter IMHO. I agree, we can do like Chromium and Firefox and use just [Spinner] Loading ...
Alejandro, for reference I reported this a time ago and did basically the same patch, although it differs in that I changed the return line in the function, don't recall why... feel free to check and close that bug too when this is solved: bug #593743
(In reply to comment #4) > Alejandro, for reference I reported this a time ago and did basically the same > patch, although it differs in that I changed the return line in the function, > don't recall why... feel free to check and close that bug too when this is > solved: bug #593743 Thanks for the reference Diego, I'll duplicate this one and upload the new patch to the other one. *** This bug has been marked as a duplicate of bug 593743 ***
I'm reopening this one because the whole thing has more problems than just this blank page issue. I'm going to upload a patch for this and then try to fix the general point.
Created attachment 151033 [details] [review] Proposed patch This patch fixes this problem in the current situation of the code, which is quite messy. In order to divide problems I'm going to upload this patch and after this focus in a more deep review of the loading logic of the embed, using the other bug 593743.
Created attachment 151045 [details] [review] Proposed patch New patch, it is based in the first patch but using the title as soon as we have it, this causes we render "[S] <uri>" until we get the real title, the loading title just appears before commit (not that much :).
The patches in bug 593743 obsolete this one.