After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 605972 - don't abort gdb'd tests
don't abort gdb'd tests
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Philip Chimento
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2010-01-03 18:31 UTC by Havoc Pennington
Modified: 2016-11-30 06:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add timeout variable and use when gdbing (2.59 KB, patch)
2010-01-03 18:31 UTC, Havoc Pennington 		none Details | Review
tests: Allow disabling abort timeout (1.07 KB, patch)
2016-11-29 08:02 UTC, Philip Chimento 		committed Details | Review

Description Havoc Pennington 2010-01-03 18:31:08 UTC 
Created attachment 150746 [details] [review]
add timeout variable and use when gdbing

make gdb-check is handy except the tests have a timeout watchdog that autokills them (useful in buildbots; not useful when stepping through code)
Comment 1 Colin Walters 2010-01-04 20:19:43 UTC 
Review of attachment 150746 [details] [review]:

Hm, why can't we just not set the crash after timeout if we see a GJS_TEST_SKIP_TIMEOUT environment variable?  1000000 is a little cheesy.
Comment 2 Havoc Pennington 2010-01-04 20:46:03 UTC 
yeah, just a disable var might be nicer. I was trying to be generic or something.
thought maybe some people would want to tune it in their buildbot maybe.
Comment 3 Colin Walters 2010-01-04 21:24:00 UTC 
Maybe have 0 mean infinite then?
Comment 4 Philip Chimento 2016-11-29 08:02:16 UTC 
Created attachment 340962 [details] [review]
tests: Allow disabling abort timeout

Run tests under GDB with GJS_TEST_SKIP_TIMEOUT=1 so that you don't get
SIGABRT while stepping through the program.

Original idea by Havoc Pennington <hp@pobox.com>.
Comment 5 Philip Chimento 2016-11-29 08:03:29 UTC 
Here's the patch with a disable var, we don't have make gdb-check anymore though.
Comment 6 Cosimo Cecchi 2016-11-29 08:46:11 UTC 
Review of attachment 340962 [details] [review]:

Sure
Comment 7 Philip Chimento 2016-11-30 06:21:43 UTC 
Attachment 340962 [details] pushed as 6d22836 - tests: Allow disabling abort timeout