GNOME Bugzilla – Bug 605891
Move Paths into Hyena.
Last modified: 2010-04-12 08:06:14 UTC
This patch moves Paths and XdgBaseDirectorySpec into Hyena, which allows it to be used by other applications (F-Spot currently ships a copy of XdgBaseDirectorySpec). This patch consists of a number of things: * XdgBaseDirectorySpec is moved into Hyena. * The legacy application data path is moved to a new LegacyPaths class. * The rest of Paths is moved into Hyena. * All other fixes are related to getting it building with the moved classes. One special thing to note is the new ApplicationName member in Paths. As I didn't want anything banshee-specific in Paths, I had to introduce this new member. This needs to be initialized at application startup.
Created attachment 150674 [details] [review] Move Paths and XdgBaseDirectorySpec into Hyena.
I just noticed that this was pushed as a git diff. So you'll probably need to use git-apply instead of patch when applying (and testing) this.
This patch is a prerequisite for being able to move Banshee.Configuration into Hyena, which I want to adopt in F-Spot. This was my main motivation for writing it, as XmlConfigurationClient depends on Paths.
Created attachment 150683 [details] [review] Updated patch Updated version, which corrects the initialization order of variables.
This patch probably still needs changes to the .csproj files, other than that, it can be reviewed (I will post an updated version with the .csproj modifications, but don't hold back on that for a review please).
Created attachment 158423 [details] [review] Move Paths and XdgBaseDirectorySpec into Hyena. This patch moves Paths and XdgBaseDirectorySpec into Hyena, which allows it to be used by other applications (F-Spot currently ships a copy of XdgBaseDirectorySpec). This patch consists of a number of things: * XdgBaseDirectorySpec is moved into Hyena. * The legacy application data path is moved to a new LegacyPaths class. * The rest of Paths is moved into Hyena. * All other fixes are related to getting it building with the moved classes. One special thing to note is the new ApplicationName member in Paths. As I didn't want anything banshee-specific in Paths, I had to introduce this new member. This needs to be initialized at application startup.
Created attachment 158424 [details] [review] Updated patch Updated patch, with a revised commit message and monodevelop updates.
Since XdgBaseDirectorySpec is already in Hyena, this part of the patch has also been dropped.
Thanks Ruben! I committed a slightly modified version of the patch, the YouTube extension and some tests did not compile. Could you make sure all extensions compile in the other big reorganisations? commit 2d1dada540c07344948c725d63f70a378012fc23 Author: Ruben Vermeersch <ruben@savanne.be> Date: Mon Apr 12 10:41:24 2010 +1000 Move `Paths` to Hyena (bgo#605891) This patch moves Paths into Hyena, which allows it to be used by other applications. This patch consists of a number of things: * The legacy application data path is moved to a new LegacyPaths class. * The rest of Paths is moved into Hyena. * All other fixes are related to getting it building with the moved class. One special thing to note is the new ApplicationName member in Paths. As I didn't want anything banshee-specific in Paths, I had to introduce this new member. This needs to be initialized at application startup. Signed-off-by: Alexander Kojevnikov <alexander@kojevnikov.com>
Oh yes sorry, I build with the youtube extension disabled due to missing dependencies. Will keep that into account in the future. Thanks!