After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 605834 - directsoundsink: 16-bit audio is always signed while 8-bit is always unsigned
directsoundsink: 16-bit audio is always signed while 8-bit is always unsigned
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Windows
: Normal normal
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-01-01 01:38 UTC by Philip Jägenstedt
Modified: 2011-07-09 23:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
modify caps to match what DirectSound always uses (819 bytes, application/octet-stream)
2010-01-01 01:38 UTC, Philip Jägenstedt
  Details
redone with git format-patch (1.37 KB, patch)
2011-07-07 10:06 UTC, Philip Jägenstedt
none Details | Review

Description Philip Jägenstedt 2010-01-01 01:38:27 UTC
Created attachment 150627 [details]
modify caps to match what DirectSound always uses

pretending to handle 8-bit signed causes distorted audio when actually given such audio, which you will get if passing 8-bit unsigned through audioconvert ! audioresample, as audioresample only handles 8-bit signed.

By the way, since this is taken directly from http://sourcecode.opera.com/gstreamer/gst-plugins-good.git/ please tell me if there's a more straightforward way of submitting patches that avoid the "diff" roundtrip and will save you the trouble of writing a new commit message when I have already done so.
Comment 1 LRN 2010-01-01 12:54:43 UTC
git format-patch -N - dumps last N commits as patches
Comment 3 Sebastian Dröge (slomo) 2011-05-23 14:29:37 UTC
What should happen with this bug now? Is there a new, git format-patch style patch? Is this still needed at all?
Comment 4 Akhil Laddha 2011-07-07 05:26:39 UTC
Philip, would you please respond to comment#3 ?
Comment 5 Philip Jägenstedt 2011-07-07 10:06:42 UTC
Created attachment 191440 [details] [review]
redone with git format-patch
Comment 6 Philip Jägenstedt 2011-07-07 10:07:32 UTC
We're still shipping Opera with this patch applies. Unless there have been changes elsewhere to filter the caps (highly unlikely) it is still needed.
Comment 7 David Schleef 2011-07-09 23:47:17 UTC
commit fbe726c3da9bb8e46291c1186a11e53866f14a9e
Author: Philip Jägenstedt <philipj@opera.com>
Date:   Fri Nov 20 10:07:43 2009 +0100

    directsoundsink: 16-bit audio is signed, 8-bit is unsigned.
    
    Pretending to handle 8-bit signed causes distorted audio when
    actually given such audio, which you will get if passing 8-bit
    unsigned through audioconvert ! audioresample, as audioresample
    only handles 8-bit signed.  Fixes #605834.
    
    Signed-off-by: David Schleef <ds@schleef.org>