Bug 605739 - invest applet lacks network-manager integration
invest applet lacks network-manager integration
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: invest-applet
git master
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2009-12-30 13:55 UTC by Enrico Minack
Modified: 2010-01-18 14:07 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Adds network manager integration (4.57 KB, patch)
2009-12-30 14:10 UTC, Enrico Minack 		accepted-commit_now Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Comment 1 Enrico Minack 2009-12-30 14:10:45 UTC 
Created attachment 150582 [details] [review]
Adds network manager integration

This makes the applet aware of current network status via network manager and dbus. The applet stops fetching quotes when the network manager says there is no network connection, and it updates quotes immediately when it comes online again. If the network manager is not available via dbus, the applet behaves as it does now.
Comment 2 Callum McKenzie 2010-01-14 02:59:17 UTC 
Review of attachment 150582 [details] [review]:

Looks good to me.
Comment 3 Callum McKenzie 2010-01-14 03:00:18 UTC 
The last comment should have ended: "commit it."
Note You need to log in before you can comment on or make changes to this bug.