After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 605704 - A white border will appear around desktop after renaming a file on the desktop
A white border will appear around desktop after renaming a file on the desktop
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Desktop
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 610345 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-12-29 22:36 UTC by aapgorilla
Modified: 2010-03-18 11:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't display a border around the desktop frame. (946 bytes, patch)
2010-03-14 02:20 UTC, Luke Symes
accepted-commit_after_freeze Details | Review
Still border in Nautilus windows (4.47 KB, image/png)
2010-03-14 12:29 UTC, Alex Hofbauer
  Details

Description aapgorilla 2009-12-29 22:36:51 UTC
Description of problem:
after renaming a file under gnome a white 2 pixel border will appear around the
entire desktop, like the desktop was put into a picture frame.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. place a file on the gnome desktop
2. rename it
3. a with border around the desktop appears
Comment 1 Götz Waschk 2009-12-29 22:48:14 UTC
I can confirm this is on Mandriva Cooker with nautilus 2.29.1, gtk 2.19.2 and glib 2.23.1.
Comment 2 Andrea Cimitan 2010-02-06 10:42:44 UTC
Same issue here, but 1px
Comment 3 aapgorilla 2010-02-09 15:18:47 UTC
1 pixel here now too
Comment 4 Hernando Torque 2010-02-09 16:15:28 UTC
Color and width of the border depend on the GTK theme, eg. with "High Contrast Inverse" it's a thick white border, while with "Clearlooks" the border is thin and gray.
Comment 5 aapgorilla 2010-02-16 15:58:51 UTC
(In reply to comment #4)
> Color and width of the border depend on the GTK theme, eg. with "High Contrast
> Inverse" it's a thick white border, while with "Clearlooks" the border is thin
> and gray.

indeed, with elementary it's 4 pixels....anyway any status report on this, I think even though it's just cosmetic that this bug is pretty major
Comment 6 Alex Hofbauer 2010-02-17 11:54:15 UTC
I also noticed this bug is triggered if you change the Desktop's background.

Right now I can see the border but I'm pretty sure I did not do either so there might be more possibilities to get that behaviour.
Comment 7 Alex Hofbauer 2010-02-17 12:08:29 UTC
Sorry for the noise but I just saw that this border can also be seen in regular nautilus windows. I just never noticed it, because with the Clearlooks engine it was too small.

Testing with eGTK theme (combination of murrine and aurora) the same 7px border is even applied to "Extra Panes".


The border itself seems to be dependent on the engine, with elementary it is drawn left and right.
Comment 8 Cosimo Cecchi 2010-02-20 14:03:57 UTC
*** Bug 610345 has been marked as a duplicate of this bug. ***
Comment 9 tekstr1der 2010-03-08 20:58:30 UTC
This issue is still present in nautilus 2.29.92. Is there any temporary workaround to prevent the border from being drawn until the bug is fixed properly?
Comment 10 Luke Symes 2010-03-09 09:41:32 UTC
Problem happens from libnautilus-private/nautilus-icon-container.c, nautilus_icon_container_start_renaming_selected_item:
~8419: gtk_widget_show (details->rename_widget);

I found this by putting "return;" in likely places in the function until the behaviour appeared.
Comment 11 mahfiaz 2010-03-12 10:38:37 UTC
I think this bugs priority should be raised. Although it is only visual and rather minor inconvenience, it is seen too often and too public, and get's triggered awfully often:
* on theme change
* on screen size change
* when plugging a external monitor (for presentation for example)
* when renaming files on desktop
Comment 12 Luke Symes 2010-03-14 02:20:27 UTC
Created attachment 156093 [details] [review]
Don't display a border around the desktop frame.

This patch fixes the issue for me when renaming files on the desktop. I also tested changing theme and desktop font; all working good with no desktop border appearing.
Comment 13 Alex Hofbauer 2010-03-14 12:25:02 UTC
Review of attachment 156093 [details] [review]:

Using this patch right now. Encountered no side-effects so far.
Comment 14 Alex Hofbauer 2010-03-14 12:29:56 UTC
Created attachment 156117 [details]
Still border in Nautilus windows

Although the above patch solves the "border on desktop" problem, there is still a grey border in Nautilus (using elementary theme).
Comment 15 Luke Symes 2010-03-14 21:35:58 UTC
@Alex Hofbauer: See this commit (this is where I found how to fix this issue for the desktop): http://git.gnome.org/browse/nautilus/commit/?id=9bc68d825f3e928e736caf213b84371607a6bd41

The bug this commit 'fixed' is: https://bugzilla.gnome.org/show_bug.cgi?id=499361
Comment #47 says: "Also it depends on the GTK widget theme used. Some themes look ugly with the
shadow and some look ugly without it."
Comment 16 Alex Hofbauer 2010-03-14 22:32:21 UTC
(In reply to comment #15)
Luke, thank you for your detailed information.

I reverted this commit to see the differences and now I think I understand the issue: Nautilus looks ugly either way. It seems there's nothing one can do about that at the moment (unless there's a workaround for gtkrc).
Comment 17 Alexander Larsson 2010-03-18 10:53:15 UTC
Review of attachment 156093 [details] [review]:

Looks good to me, but we're in a freeze, i'll ask for a break.
Comment 18 Alexander Larsson 2010-03-18 11:42:51 UTC
pushed.