After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 605587 - draw_spell_error() doesn't restore GC fill style
draw_spell_error() doesn't restore GC fill style
Status: RESOLVED FIXED
Product: GtkHtml
Classification: Other
Component: Rendering
3.28.x
Other Linux
: Normal normal
: ---
Assigned To: Srinivasa Ragavan
Srinivasa Ragavan
Depends on:
Blocks:
 
 
Reported: 2009-12-28 08:31 UTC by Michel Dänzer
Modified: 2010-01-07 14:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed fix (740 bytes, patch)
2009-12-28 08:31 UTC, Michel Dänzer 		committed Details | Review

Description Michel Dänzer 2009-12-28 08:31:26 UTC 
Created attachment 150486 [details] [review]
Proposed fix

The function draw_spell_error() calls

        gdk_gc_set_fill (gdk_painter->gc, GDK_OPAQUE_STIPPLED);

presumably for underlining misspelled words. However, it doesn't reset the GC
fill style after doing its drawing operations, so the opaque stippled style
remains effective for unrelated drawing operations, potentially slowing them
down unnecessarily. The attached patch fixes this.
Comment 1 Milan Crha 2010-01-07 14:29:55 UTC 
Thanks for a bug report. Change looks OK.

Created commit 9c3b728 in gtkhtml master (3.29.5+)