GNOME Bugzilla – Bug 605552
Use Argyll tools installed in /usr/local/bin as well
Last modified: 2009-12-28 10:25:52 UTC
Created attachment 150461 [details] [review] Also evaluate /usr/local/bin when searching for Argyll tools (prefer) Currently GCM searches for Debian modified filenames of the Argyll tools and then looks for the original filenames in /usr/bin. However it's entirely possible for folks to have installed Argyll from a binary tarball (or their own source compile) into /usr/local/bin, and thus GCM should support that. The question is in what order should we check, there a two options: - Flexible, preferring /usr/local over everything else. For example a distribution like Fedora or Debian does not provide an up to date copy of Argyll, the user can still untar a binary tarball from argyllcms.com into /usr/local/bin to get the latest and greatest from Argyll. This also does imply, if a user untars a binary tarball from argyllcms.com into /usr/local/bin he'll be "suddenly" using a different version of Argyll, without being explicitly told so, even when the old system copy of Argyll is still present. - Safe/Fallback, preferring everything else over /usr/local, no risks here, but it's not as flexible. This is of course a matter of policy.
Created attachment 150462 [details] [review] Also evaluate /usr/local/bin when searching for Argyll tools (safe/fallback) Here's the safe/fallback version of the patch.
Created attachment 150465 [details] [review] Also evaluate /usr/local/bin when searching for Argyll tools (prefer) (fixed) The previous patch had g_free in the wrong place, because of some sloppy copy-pasting of mine. This patch should have that fixed.
Review of attachment 150465 [details] [review]: Looks fine, thanks.