GNOME Bugzilla – Bug 605538
start voice calls
Last modified: 2018-08-17 18:49:36 UTC
gnome-phone-manager can send sms, but not launch voice calls. the attached patches add a menu item "Start Call" to the context menu of the icon, which starts a dialogue similar to the "Send Message" but without a text input field. the phone then initiates a regular phone call. most of the code is copy/pasted from sms sending, stripped off the message stuff and adapted for call starting from gnokii examples. it is split in two patches, one dealing with gnokii in libgsm, one wires everything up on the front end. maybe i should add that the patches are about 1.5 years old; i somehow missed reporting that back then.
Created attachment 150444 [details] [review] backend patch
Created attachment 150445 [details] [review] frontend patch
Review of attachment 150444 [details] [review]: g_strlcpy () always NUL-terminates the string, so this line isn't needed: call_info.number[sizeof(call_info.number)-1] = '\0'; http://library.gnome.org/devel/glib/unstable/glib-String-Utility-Functions.html#g-strlcpy
Review of attachment 150445 [details] [review]: Reusing the e_phone_entry used for sending SMS means that only mobile numbers are shown.
concerning the NUL line: yes, that's the kind of problems i expected from copy/pasting (that part of the code came from the dialvoice.c example, which uses snprintf). concerning the entry box: at the time of writing, i was not aware that this thing is not a textbox at all. would adding a parameter to limit the type of phone numbers to the widget be the way to go here? furthermore: would you be willing to write the patch for that part? i can try, but from a first look at e-phone-entry.c it seems this means learning the ways of libedataserver, which you are probably familiar with.
(In reply to comment #4) > Review of attachment 150445 [details] [review]: > > Reusing the e_phone_entry used for sending SMS means that only mobile numbers > are shown. It would be easy enough to make that a property though. This would be a construct-only property, so you'd need to find an object that uses those as an example. But you'd really just switch between the current EContactField fields (in e_phone_entry_init()) and one with more phone numbers. Which phone number is actually fetched from the entry is actually in the front-end bits.
gnome-phone-manager is not under active development anymore since 2013. Its codebase has been archived: https://gitlab.gnome.org/Archive/phonemgr/commits/master Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the responsibility for active development again.