After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 605318 - Remove deprecated GTK+ symbols
Remove deprecated GTK+ symbols
Status: RESOLVED FIXED
Product: pygtk
Classification: Bindings
Component: gdk
Git Master
Other All
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
[gnome3-important]
Depends on:
Blocks: 585692
 
 
Reported: 2009-12-23 17:17 UTC by Javier Jardón (IRC: jjardon)
Modified: 2011-03-22 19:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove some deprecated symbols (6.24 KB, patch)
2009-12-23 17:20 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review

Description Javier Jardón (IRC: jjardon) 2009-12-23 17:17:37 UTC
According to http://www.gnome.org/~fpeters/299.html Balsa uses deprecated
symbols that will be removed for GTK+ 3.

See http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/GTK%2B
Comment 1 Javier Jardón (IRC: jjardon) 2009-12-23 17:20:35 UTC
Created attachment 150308 [details] [review]
Remove some deprecated symbols

Still remaining:

GTK_OBJECT_FLOATING
GtkArg
gtk_type_init
Comment 2 Javier Jardón (IRC: jjardon) 2010-01-04 09:16:13 UTC
Comment on attachment 150308 [details] [review]
Remove some deprecated symbols

commit 68763a97385dd74ccd12ef4decd662de9dd2c2ab
Comment 3 Dieter Verfaillie 2010-12-23 21:38:17 UTC
Hi Javier, as pygtk will not offer bindings for GTK+3 (but
pygobject's gi support will), can we close this bug?
Comment 4 André Klapper 2011-03-03 21:15:42 UTC
[Removing GNOME3.0 target as decided in release-team meeting on March 03, 2011.
This report has an "important" categorisation for GNOME3.0 but is not considered a hard blocker. For querying use the corresponding whiteboard entry added.]
Comment 5 John Stowers 2011-03-09 22:14:50 UTC
I'm not sure what to do about this bug. There is much more depreciated in PyGTK than this patch covers, much impossible to fix because of our own API guarantees. PyGTK will never run against gtk+-3.0 so i'm not sure if it is worthwhile.

What do you think Andre?
Comment 6 Javier Jardón (IRC: jjardon) 2011-03-10 21:04:27 UTC
The idea of removing deprecated code is to easy the port of app/libraries to GTK+3.
But I think is always a good idea not use deprecated code in you app/library, so we can leave this open until someone fix the latest bits.
Comment 7 John Stowers 2011-03-10 21:19:30 UTC
We generate bindings for deprecated code - so for us to remove that deprecated code it would break users of PyGTK (maybe, likely).

This would not necessarily help them port to PyGTK 3 because
 * there is no PyGTK 3
 * if they want to use gtk+-3 they have to port their code to pygobject + g-i anyway (which is a larger API break).

So PyGTK = Gtk+-2, and because there is no chance of the deprecated code being removed *in the gtk+-2 series* I don't want to risk it.

Does that sound reasonable?
Comment 8 Javier Jardón (IRC: jjardon) 2011-03-10 21:27:43 UTC
John, there was a misunderstanding here.

I didnt mean remove the (sometimes deprecated) API pygtk provides, I meant replace deprecated APIs pygtk is using itself, if Its possible (like the firt patch I sent)
Comment 9 John Stowers 2011-03-10 21:29:25 UTC
OK. That makes more sense.

I'm doing a PyGTK release today.
Comment 10 Frederic Peters 2011-03-17 18:23:43 UTC
The release happened, can we close this bug, or is it still missing something?
Comment 11 John Stowers 2011-03-22 19:56:48 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.