GNOME Bugzilla – Bug 605309
Show the status of accounts in the treeview
Last modified: 2011-08-29 10:12:28 UTC
Now that bug #599153 is fixed when can see the status of an accout by clicking on it. It would be good to be able to see the status of *all* the accounts at once by adding a status icon in the accounts treeview.
Created attachment 151467 [details] [review] http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/accounts-status-605309 src/empathy-accounts-dialog.c | 130 ++++++++++++++++++++++++++++++++--------- 1 files changed, 103 insertions(+), 27 deletions(-)
Review of attachment 151467 [details] [review]: I inlined some comments; other than that, looks good to me. ::: src/empathy-accounts-dialog.c @@ +801,3 @@ + return GTK_STOCK_DIALOG_ERROR; + + presence = TP_CONNECTION_PRESENCE_TYPE_OFFLINE; This line is never reached; either you return the error icon or the offline one I guess (I think the former is better). @@ +806,3 @@ + { + /* Account is connecting. Display a blinking account alternating between + * the offline icon and the requested presence. */ In this case, I think it's better to show a blinking sensitive/insensitive icon for the requested presence, as changing an icon on the fly while blinking does not look very good IMO.
(In reply to comment #2) > Review of attachment 151467 [details] [review]: > ::: src/empathy-accounts-dialog.c > @@ +801,3 @@ > + return GTK_STOCK_DIALOG_ERROR; > + > + presence = TP_CONNECTION_PRESENCE_TYPE_OFFLINE; > > This line is never reached; either you return the error icon or the offline one > I guess (I think the former is better). Actually it is. If the account is enabled but offline (because your presence is set to offline) we should display the offline icon, not the error one. But the identation was wrong, I fixed it.
> @@ +806,3 @@ > + { > + /* Account is connecting. Display a blinking account alternating between > + * the offline icon and the requested presence. */ > > In this case, I think it's better to show a blinking sensitive/insensitive icon > for the requested presence, as changing an icon on the fly while blinking does > not look very good IMO. I never really like the sensitive/unsensitive blinking of the protocol icon and find it not very easy to see and understand. I tried this approach which seems clearer to me to see how it goes. But I'm ready to be convinced that's your solution is actually better. What the other people think?
what about showing a tiny spinner while connecting? Just like its done in the infobar... (I don't like blinking at all ;) )
(In reply to comment #5) > what about showing a tiny spinner while connecting? Just like its done in the > infobar... That's currently not possible as there is no widget inheriting from GtkCellRenderer implemeting a spinner. I discussed IRL with Sjoerd and he agreed that switching icon is clearer than greying.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
*** Bug 607787 has been marked as a duplicate of this bug. ***
is it fixed in 2.29.5?
I am using 2.29.5 but I don't seem to know where it is fixed
That will be in 2.29.6 which should be released today.