After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 605186 - Use G_DEFINE_INTERFACE macro
Use G_DEFINE_INTERFACE macro
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.20.x
Other All
: Normal minor
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2009-12-22 01:16 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-08-25 22:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtkcelleditable (6.70 KB, patch)
2009-12-22 01:40 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
gtkcelleditable.v2 (6.65 KB, patch)
2010-04-08 23:40 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
gtkorientable (1.91 KB, patch)
2010-04-09 00:38 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
gtkbuildable (1.05 KB, patch)
2010-04-09 00:51 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
gtkbuildable.v2 (1.07 KB, patch)
2010-04-09 00:54 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
gtkactivatable (2.09 KB, patch)
2010-04-14 14:33 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
gtkfilechooser (5.25 KB, patch)
2010-08-25 20:15 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
gtkrecentchooser (5.47 KB, patch)
2010-08-25 20:16 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
gtkcelllayout (1.33 KB, patch)
2010-08-25 20:36 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
gtktoolshell (1.23 KB, patch)
2010-08-25 20:42 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
gtksizerequest (1.62 KB, patch)
2010-08-25 21:02 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2009-12-22 01:16:49 UTC 
Use the new gobject G_DEFINE_INTERFACE macro, see http://library.gnome.org/devel/gobject/unstable/gobject-Type-Information.html#G-DEFINE-INTERFACE
Comment 1 Javier Jardón (IRC: jjardon) 2009-12-22 01:40:29 UTC 
Created attachment 150213 [details] [review]
gtkcelleditable

Here a patch for GtkCellEditable interface.
Comment 2 Javier Jardón (IRC: jjardon) 2010-04-08 23:40:59 UTC 
Created attachment 158246 [details] [review]
gtkcelleditable.v2

This is the correct patch; It's a GTK_TYPE_WIDGET, not G_TYPE_OBJECT
Comment 3 Javier Jardón (IRC: jjardon) 2010-04-09 00:38:26 UTC 
Created attachment 158247 [details] [review]
gtkorientable
Comment 4 Javier Jardón (IRC: jjardon) 2010-04-09 00:51:44 UTC 
Created attachment 158248 [details] [review]
gtkbuildable
Comment 5 Javier Jardón (IRC: jjardon) 2010-04-09 00:54:11 UTC 
Created attachment 158249 [details] [review]
gtkbuildable.v2
Comment 6 Matthias Clasen 2010-04-09 15:04:57 UTC 
These need some careful checking wrt. to inheritance of superclass implementations of the interface. From what I recall, changing from base_init to class_init can change the behaviour, and all these interfaces have implementations that are ancestors of each other.
Comment 7 Dan Winship 2010-04-12 15:53:19 UTC 
I don't remember the details of this any more, but assuming my comments in bug 320482 comment 5 were correct, then there is only a difference when the interface init method fills in vtable entries, which none of these classes do.
Comment 8 Matthias Clasen 2010-04-12 23:42:49 UTC 
Ok then. Go ahead. If there happens to be breakage, we'll learn about it soon enough...
Comment 9 Javier Jardón (IRC: jjardon) 2010-04-13 05:45:20 UTC 
Comment on attachment 158246 [details] [review]
gtkcelleditable.v2

commit e53489721644bf8b267edf2b2a665c75c5008423
Comment 10 Javier Jardón (IRC: jjardon) 2010-04-13 05:45:54 UTC 
Comment on attachment 158247 [details] [review]
gtkorientable

commit 9f6e03f2310762f437e298208182098e0fdad86d
Comment 11 Javier Jardón (IRC: jjardon) 2010-04-13 05:46:29 UTC 
Comment on attachment 158249 [details] [review]
gtkbuildable.v2

commit af0a7aea5f6fc508ef0f5dd83babc39dc61225c6
Comment 12 Javier Jardón (IRC: jjardon) 2010-04-14 14:33:11 UTC 
Created attachment 158719 [details] [review]
gtkactivatable
Comment 13 Matthias Clasen 2010-08-25 04:15:00 UTC 
Review of attachment 158719 [details] [review]:

Looks ok
Comment 14 Javier Jardón (IRC: jjardon) 2010-08-25 13:17:34 UTC 
Comment on attachment 158719 [details] [review]
gtkactivatable

commit 45e217668377cfb8bb0de23edf8c66549ec1b634
Comment 15 Javier Jardón (IRC: jjardon) 2010-08-25 20:15:57 UTC 
Created attachment 168762 [details] [review]
gtkfilechooser
Comment 16 Javier Jardón (IRC: jjardon) 2010-08-25 20:16:21 UTC 
Created attachment 168763 [details] [review]
gtkrecentchooser
Comment 17 Javier Jardón (IRC: jjardon) 2010-08-25 20:36:51 UTC 
Created attachment 168765 [details] [review]
gtkcelllayout
Comment 18 Javier Jardón (IRC: jjardon) 2010-08-25 20:42:25 UTC 
Created attachment 168766 [details] [review]
gtktoolshell
Comment 19 Javier Jardón (IRC: jjardon) 2010-08-25 21:02:39 UTC 
Created attachment 168767 [details] [review]
gtksizerequest

The last one, I think
Comment 20 Matthias Clasen 2010-08-25 22:21:17 UTC 
Review of attachment 168762 [details] [review]:

Looks ok
Comment 21 Matthias Clasen 2010-08-25 22:22:04 UTC 
Review of attachment 168763 [details] [review]:

Looks ok
Comment 22 Matthias Clasen 2010-08-25 22:22:51 UTC 
Review of attachment 168765 [details] [review]:

Looks ok
Comment 23 Matthias Clasen 2010-08-25 22:23:43 UTC 
Review of attachment 168766 [details] [review]:

Looks ok
Comment 24 Matthias Clasen 2010-08-25 22:24:27 UTC 
Review of attachment 168767 [details] [review]:

Looks ok
Comment 25 Matthias Clasen 2010-08-25 22:24:28 UTC 
Review of attachment 168767 [details] [review]:

Looks ok
Comment 26 Javier Jardón (IRC: jjardon) 2010-08-25 22:45:15 UTC 
Comment on attachment 168762 [details] [review]
gtkfilechooser

commit c1476c951ec81e883ff8e9c287855320ae54580c
Comment 27 Javier Jardón (IRC: jjardon) 2010-08-25 22:45:36 UTC 
Comment on attachment 168763 [details] [review]
gtkrecentchooser

commit 208e548ab1d3cb5662d83cc0bb0033756456df49
Comment 28 Javier Jardón (IRC: jjardon) 2010-08-25 22:45:52 UTC 
Comment on attachment 168765 [details] [review]
gtkcelllayout

commit 24fedeccaccae59a8dc1b8c6e33cd8a3f9a4a32f
Comment 29 Javier Jardón (IRC: jjardon) 2010-08-25 22:46:32 UTC 
Comment on attachment 168766 [details] [review]
gtktoolshell

commit 523ea1c65614bed598a4d8e52e2981e7fe098f09
Comment 30 Javier Jardón (IRC: jjardon) 2010-08-25 22:47:00 UTC 
Comment on attachment 168767 [details] [review]
gtksizerequest

commit 1b77e36a5943491d27a1991c30f9e79659b1db94
Comment 31 Javier Jardón (IRC: jjardon) 2010-08-25 22:47:41 UTC 
All committed to the master branch, thanks for the reviews.