After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 605098 - GNOME Goal: Remove deprecated Glib symbols
GNOME Goal: Remove deprecated Glib symbols
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: Disk Mounter (drivemount)
git master
Other All
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks: 560423
 
 
Reported: 2009-12-21 00:26 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-01-05 19:06 UTC
See Also:
GNOME target: 2.30.x
GNOME version: ---

Attachments
Remove deprecated glib symbols (2.64 KB, patch)
2009-12-21 00:28 UTC, Javier Jardón (IRC: jjardon) 		needs-work Details | Review
Remove deprecated glib symbols.v2 (2.64 KB, patch)
2010-01-05 15:24 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2009-12-21 00:26:41 UTC 
Patch attached
Comment 1 Javier Jardón (IRC: jjardon) 2009-12-21 00:28:48 UTC 
Created attachment 150138 [details] [review]
Remove deprecated glib symbols

Substitude g_mount_eject(), g_volume_eject() and g_mount_unmount().

Also, the new required GLIB version is 2.22.
Comment 2 Allison Karlitskaya (desrt) 2010-01-05 15:10:29 UTC 
Review of attachment 150138 [details] [review]:

looks okay except for one obvious typo.  please test this patch.

::: drivemount/drive-button.c
@@ +774,3 @@
 	}
     } else if (self->mount) {
+	g_mount_unmount_with_opeartion (self->mount, G_MOUNT_UNMOUNT_NONE,

did you try to compile this? :)
Comment 3 Javier Jardón (IRC: jjardon) 2010-01-05 15:24:43 UTC 
Created attachment 150842 [details] [review]
Remove deprecated glib symbols.v2

Hello Ryan,

you caught me ;). Here a new patch.
Comment 4 André Klapper 2010-01-05 18:30:47 UTC 
Javier: Assuming as per last comment "looks okay" that you can just commit it with the typo fix.
If not, Ryan can still beat me up at the next conference. ;-)
Comment 5 Javier Jardón (IRC: jjardon) 2010-01-05 18:59:36 UTC 
Comment on attachment 150842 [details] [review]
Remove deprecated glib symbols.v2

commit 921aa942fd26c505c767b3eb896b971ce59ada4d
Comment 6 Javier Jardón (IRC: jjardon) 2010-01-05 19:06:17 UTC 
Ryan, I committed the patch under the Andre protection ;). gnome-applets is clean now :)