After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 605035 - Free the family string in st_theme_node_get_font()
Free the family string in st_theme_node_get_font()
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
2.28.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-12-20 03:16 UTC by Carlos Martín Nieto
Modified: 2010-01-04 18:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't leak the font family name (814 bytes, patch)
2009-12-20 03:16 UTC, Carlos Martín Nieto 		committed Details | Review

Description Carlos Martín Nieto 2009-12-20 03:16:31 UTC 
Created attachment 150092 [details] [review]
Don't leak the font family name

A copy of the string is made by pango_font_description_set_family() and we don't need the string anymore, so we should free it.

 Otherwise we leak a few bytes every time st_theme_node_get_font() gets called.
Comment 1 Colin Walters 2010-01-04 18:47:30 UTC 
Review of attachment 150092 [details] [review]:

Looks good, thank you!