After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 604957 - alt-f2 completion needs to ignore broken symlinks (and general stat errors)
alt-f2 completion needs to ignore broken symlinks (and general stat errors)
Status: RESOLVED DUPLICATE of bug 604958
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-12-18 22:21 UTC by Colin Walters
Modified: 2009-12-21 15:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[runDialog] Ignore query_info failures (1.34 KB, patch)
2009-12-18 22:27 UTC, Colin Walters 		needs-work Details | Review

Description Colin Walters 2009-12-18 22:21:03 UTC 
For various reasons we could fail to call .query_info on an executable (selinux for example can deny permission to stat(), and also broken symlinks).

We should catch any gio errors and ignore.  For now we could just catch all errors, but we need support in gjs for reading specific GError information.
Comment 1 Colin Walters 2009-12-18 22:27:00 UTC 
Created attachment 150038 [details] [review]
[runDialog] Ignore query_info failures

We could fail to stat() files for several reasons; SELinux and
dangling symlinks are likely candidates.  Rather than failing
entirely, just ignore them.
Comment 2 Owen Taylor 2009-12-21 15:23:34 UTC 
Review of attachment 150038 [details] [review]:

I really don't want unlogged, ignore-all errors catches in gnome-shell. period. This is the same as bug 604958, which got dup'ed on bug 604978, which is a big roll-up patch. The patch in bug 604978 also has a blanket catch, and I'm equally opposed to it there too.
Comment 3 Owen Taylor 2009-12-21 15:24:09 UTC 

*** This bug has been marked as a duplicate of bug 604958 ***