After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 604925 - qtmux shouldn't accept adts aac
qtmux shouldn't accept adts aac
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 598350
 
 
Reported: 2009-12-18 15:37 UTC by Thiago Sousa Santos
Modified: 2010-01-11 16:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thiago Sousa Santos 2009-12-18 15:37:46 UTC 
When muxing aac, qtmux should only accept raw format. The problem here is how to detect and expose that in the template caps.

Raw aac can be identified by the presence of codec_data in the caps, but there is no way to signal that qtmux accepts aac caps if it has codec_data (whatever that field contains).

I discussed this briefly with Tim and Mark and we have the following ideas/suggestions:

1) Create a way to expose in template caps that an element needs a certain field without specifying any values for it.

2) Add a new field to aac caps, something like framing/layout/format to identify if it is ADTS or raw or whatever.

Apparently this same problem applies to h264.

Ideas? Votes?
Comment 1 David Schleef 2009-12-18 20:18:21 UTC 
A new field is more descriptive and discoverable.
Comment 2 Thiago Sousa Santos 2010-01-11 16:51:07 UTC 
Fixed by these commits.

commit a428ad82c765ac5fc18b939b4f82a824a97a3dae
Author: Thiago Santos <thiago.sousa.santos@collabora.co.uk>
Date:   Mon Jan 11 13:13:41 2010 -0300

    Rename aac's stream-format 'none' to 'raw'
    
    Renames aac's stream-format from previous commits from none to
    raw

commit 5b8b363310cae46e63c6bebfae0bf24da9e1d92e
Author: Thiago Santos <thiago.sousa.santos@collabora.co.uk>
Date:   Mon Jan 11 10:34:32 2010 -0300

    qtmux: Only accept stream-format='none' aac
    
    Only accept raw aac streams (stream-format=none) to avoid
    generating invalid files.
    
    Fixes #604925

commit 635b0c1129a748db6bd0e44a3961ee7f1f723b57
Author: Thiago Santos <thiago.sousa.santos@collabora.co.uk>
Date:   Mon Jan 11 09:48:34 2010 -0300

    faac: Add format to output caps
    
    Adds 'stream-format' to output caps to inform if the stream is
    adts or raw. This makes it possible for muxers to reject
    input streams on caps if they don't support adts instead of
    generating a invalid file.
    
    Fixes #604925