After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 604904 - Failure to build on OpenSolaris
Failure to build on OpenSolaris
Status: RESOLVED FIXED
Product: gnome-commander
Classification: Other
Component: application
1.2.x
Other Solaris
: Normal normal
: 1.2.9
Assigned To: epiotr
epiotr
Depends on:
Blocks:
 
 
Reported: 2009-12-18 12:52 UTC by padraig.obriain
Modified: 2009-12-18 17:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description padraig.obriain 2009-12-18 12:52:39 UTC 
gnome-commander 1.2.8.4 fails to build on OpenSolaris as NAME_MAX is not defined.

The patch belows works for me.

--- /usr/tmp/gnome-commander-1.2.8.4/src/gnome-cmd-advrename-lexer.h	2009-10-20 22:13:42.000000000 +0100
+++ src/gnome-cmd-advrename-lexer.h	2009-12-18 12:17:23.843242000 +0000
@@ -23,6 +23,10 @@
 
 #include "gnome-cmd-file.h"
 
+#ifndef NAME_MAX
+#define NAME_MAX (FILENAME_MAX)
+#endif
+
 void gnome_cmd_advrename_reset_counter(long start=1, int precision=-1, int step=1);
 void gnome_cmd_advrename_parse_template(const char *template_string, gboolean &has_counters);
 char *gnome_cmd_advrename_gen_fname(GnomeCmdFile *f, size_t new_fname_size=NAME_MAX);
Comment 1 epiotr 2009-12-18 17:57:48 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.