After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 604895 - annotation updates for GtkImage, GtkIconSize
annotation updates for GtkImage, GtkIconSize
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2009-12-18 11:01 UTC by Dan Winship
Modified: 2009-12-19 09:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix out/transfer annotations on GtkImage getters (4.41 KB, patch)
2009-12-18 11:02 UTC, Dan Winship 		committed Details | Review
Change GtkIconSize to int in params/return values (15.47 KB, patch)
2009-12-18 11:02 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2009-12-18 11:01:56 UTC 
qv bug 601425
Comment 1 Dan Winship 2009-12-18 11:02:01 UTC 
Created attachment 149977 [details] [review]
Fix out/transfer annotations on GtkImage getters
Comment 2 Dan Winship 2009-12-18 11:02:05 UTC 
Created attachment 149978 [details] [review]
Change GtkIconSize to int in params/return values

GtkIconSize is an extensible enumeration (via
gtk_icon_size_register()), so methods that claim to take/return a
GtkIconSize need to actually use "int" to work correctly with bindings
that are strict about enum values.
Comment 3 Matthias Clasen 2009-12-19 02:47:11 UTC 
Looks ok to me. Does gtk-doc do a reasonable job with these annotations by now ?
Comment 4 Dan Winship 2009-12-19 09:32:46 UTC 
(In reply to comment #3)
> Does gtk-doc do a reasonable job with these annotations by now

gtk-doc 1.11 was a little broken, but it appears that gtk-doc 1.12 was released yesterday, which should be fine. (It's been working fine in git gtk-doc forever, there just hadn't been a new release.)
Comment 5 Dan Winship 2009-12-19 09:35:00 UTC 
Attachment 149977 [details] pushed as 6afa3b9 - Fix out/transfer annotations on GtkImage getters
Attachment 149978 [details] pushed as 0b4af24 - Change GtkIconSize to int in params/return values