After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 604859 - Add Since: 2.4 tags to a few functions
Add Since: 2.4 tags to a few functions
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Documentation
2.19.x
Other Linux
: Normal trivial
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2009-12-17 21:09 UTC by Torsten Schoenfeld
Modified: 2009-12-18 20:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add Since: 2.4 tags to gtk_bindings_activate_event, gtk_window_propagate_key_event and gtk_window_activate_key (1.10 KB, patch)
2009-12-17 21:09 UTC, Torsten Schoenfeld 		committed Details | Review

Description Torsten Schoenfeld 2009-12-17 21:09:32 UTC 
Created attachment 149942 [details] [review]
Add Since: 2.4 tags to gtk_bindings_activate_event, gtk_window_propagate_key_event and gtk_window_activate_key

This patch adds Since: 2.4 tags to gtk_bindings_activate_event, gtk_window_propagate_key_event and gtk_window_activate_key.
Comment 1 Javier Jardón (IRC: jjardon) 2009-12-17 23:10:25 UTC 
Review of attachment 149942 [details] [review]:

The patch looks good to me, waiting for maintainer aproval
Comment 2 Javier Jardón (IRC: jjardon) 2009-12-17 23:13:19 UTC 
Review of attachment 149942 [details] [review]:

::: gtk/gtkwindow.c
@@ +5124,1 @@
  **/

You can remove the second '*' here

@@ +8211,1 @@
  **/

You can remove the second '*' here
Comment 3 Matthias Clasen 2009-12-18 15:02:39 UTC 
Looks good to commit, with or without the extra '*'s stripped (I personally hate them, but fighting them adds noise to git history...
Comment 4 Javier Jardón (IRC: jjardon) 2009-12-18 20:01:44 UTC 
Comment on attachment 149942 [details] [review]
Add Since: 2.4 tags to gtk_bindings_activate_event, gtk_window_propagate_key_event and gtk_window_activate_key

commit 0addda20289c46e7b295000dfd46881492106710

I've finally removed the second '*'
Comment 5 Javier Jardón (IRC: jjardon) 2009-12-18 20:03:47 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release.

Thank you Torsten for your bug report.

PD: I'd suggest you to use the git format-patch command next time: take a look here: http://live.gnome.org/GnomeLove/SubmittingPatches