After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 604840 - Add introspection support
Add introspection support
Status: RESOLVED DUPLICATE of bug 598536
Product: gedit
Classification: Applications
Component: general
Other All
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks: 585444
Reported: 2009-12-17 14:26 UTC by Johan (not receiving bugmail) Dahlin
Modified: 2010-06-20 09:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Add introspection support (7.66 KB, patch)
2009-12-17 14:26 UTC, Johan (not receiving bugmail) Dahlin
needs-work Details | Review
Fix a gtk-doc bug found by g-ir-scanner (997 bytes, patch)
2009-12-17 14:26 UTC, Johan (not receiving bugmail) Dahlin
committed Details | Review

Description Johan (not receiving bugmail) Dahlin 2009-12-17 14:26:44 UTC
GtkSourceView should provide introspection support by itself.
I'm also including a gtk-doc bug patch found by the g-ir-scanner
Comment 1 Johan (not receiving bugmail) Dahlin 2009-12-17 14:26:47 UTC
Created attachment 149916 [details] [review]
Add introspection support
Comment 2 Johan (not receiving bugmail) Dahlin 2009-12-17 14:26:51 UTC
Created attachment 149917 [details] [review]
Fix a gtk-doc bug found by g-ir-scanner
Comment 3 Ignacio Casal Quinteiro (nacho) 2009-12-17 14:29:55 UTC
This is a dup of I leave it opened to check both patches.
Comment 4 Ignacio Casal Quinteiro (nacho) 2009-12-17 15:44:33 UTC
Review of attachment 149916 [details] [review]:

Just to know, do introspection works in win32? If not is it going to be added support soon?

@@ +21,1 @@

This is wrong, it should be .m4

::: gtksourceview/
@@ +105,3 @@
+INTROSPECTION_COMPILER_ARGS = --includedir=$(srcdir)
+INTROSPECTION_SCANNER_ARGS = --add-include-path=$(srcdir)

includedir and add-include-path is suppose to work recursively? if not you should add also the completion-provider folder
Comment 5 Johan (not receiving bugmail) Dahlin 2009-12-17 16:45:09 UTC
It was tested some time ago on win32, probably bitrotten by now. There's nothing fundamental against getting it to work on windows, mainly build issues. Can't see why it can't be enabled on other platforms until it builds properly on windows, as it clearly provides application features on other platforms.

The completion-provider directory should only be added if it contains public API, as it doesn't install any headers I assumed it was private so I didn't add it.

The includedir/add-include-path are not really what you think they are, they're mainly internal to introspection and has nothing to do with C headers/sources.
Comment 6 Ignacio Casal Quinteiro (nacho) 2009-12-17 17:02:50 UTC
Well, I didn't say to not include it until win32 is supported, as I said above it was just to know. About the completion-provider it has public api. gtksourcecompletionwords.h <- so it is needed something else for that? Apart from that the patch looks good to me.
Comment 7 Johan (not receiving bugmail) Dahlin 2009-12-17 17:16:39 UTC
Oops, I missed that it was installed, I stand corrected.

There's however a slight API problem, the GtkSourceCompletionWords uses the "GtkSource" prefix instead of "GtkSourceView" but it's part of the same .so.
It should ideally use another namespace prefix OR be put in another separate .so.

I think it's safe to add introspection support without this until it's decided how it relates to the GtkSourceView API.
Comment 8 Ignacio Casal Quinteiro (nacho) 2009-12-17 17:29:18 UTC
mmm, but the right prefix for is GtkSource, isn't it? I mean for gtksourcecompletion is gtksource, for gtksourcelanguage <- again gtksource, same for gtksourcegutter etc. Not sure if that's what you are asking here.
Comment 9 Ignacio Casal Quinteiro (nacho) 2010-06-20 09:57:09 UTC

*** This bug has been marked as a duplicate of bug 598536 ***