GNOME Bugzilla – Bug 604834
ctr+w in presentation mode gives "white screen"
Last modified: 2014-03-17 12:41:40 UTC
When I open some PDF in evince (2.28.2) and hit ctrl+w, then it closes the document, as it should. But while in "Presentation" mode (F5), hitting ctrl+w leads toe a white screen. Pushing any button then makes the white simply vanish and gets you back to the presentation. What would be expected is that also in Presentation mode, ctrl+w should close the document.
Yes I can confirm this in Ubuntu 9.10 with Evince Version 2.28.1
I think not should close the document, ctrl+w should close the Presentation Mode.
Fixed in git master. Thanks for reporting.
that bug seems to still be there with 3.10.3, reopening (see https://bugs.launchpad.net/ubuntu/+source/evince/+bug/1289581)
Reproducible with git master.
Created attachment 272100 [details] [review] EvViewPresentation: Exit from Presentation Mode (F5) by pressing Ctrl+W
Review of attachment 272100 [details] [review]: Thanks for the patch, but this is not correct. ::: libview/ev-view-presentation.c @@ +1128,3 @@ case GDK_KEY_w: case GDK_KEY_W: + if (event->state & GDK_CONTROL_MASK) { I think we should actually propagate any key event when the state is not 0. @@ +1129,3 @@ case GDK_KEY_W: + if (event->state & GDK_CONTROL_MASK) { + g_signal_emit_by_name(widget, "finished"); This is not the way to finish a widget, you should call gtk_widget_destroy instead, but in this case, CTRL+W is already handled by the window, not by the view itself.
I've just pushed a fix for this myself, because I'm going to release today.