After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 604782 - Gtk2::ListStore remove() on gtk 2.0.x
Gtk2::ListStore remove() on gtk 2.0.x
Status: VERIFIED FIXED
Product: gnome-perl
Classification: Bindings
Component: Gtk2
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk2-perl-bugs
gtk2-perl-bugs
Depends on:
Blocks:
 
 
Reported: 2009-12-16 22:43 UTC by Kevin Ryde
Modified: 2010-01-09 19:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
returning boolean in gtk 2.0 too (1.43 KB, patch)
2009-12-16 22:43 UTC, Kevin Ryde 		committed Details | Review
same for Gtk2::TreeStore remove() (3.00 KB, patch)
2009-12-28 00:21 UTC, Kevin Ryde 		committed Details | Review

Description Kevin Ryde 2009-12-16 22:43:58 UTC 
Created attachment 149881 [details] [review]
returning boolean in gtk 2.0 too

This is an idea to get a return value from $liststore->remove even when compiled against gtk 2.0.x, per a FIXME in the current sources.  I don't suppose anyone would be using 2.0.x, but the later behaviour is quite easily emulated.

I don't have an actual 2.0 to run, so this is based on a reading of its sources and a test run on gtk 2.18.
Comment 1 Torsten Schoenfeld 2009-12-17 21:03:33 UTC 
Review of attachment 149881 [details] [review]:

For fun, I built a gtk+ 2.0 sandbox and tested the patch.  Works fine.  Committed, with the corresponding test changes: <http://git.gnome.org/cgit/perl-Gtk2/commit/?id=ad47d5ccb78e>.
Comment 2 Kevin Ryde 2009-12-28 00:21:48 UTC 
Created attachment 150479 [details] [review]
same for Gtk2::TreeStore remove()
Comment 3 Kevin Ryde 2009-12-28 00:23:02 UTC 
I missed the tests being conditionalized on the version :).

I see the same can be done for remove in Gtk2::TreeStore, which I also forgot to look at.  New attachment and reopen for that ...
Comment 4 Torsten Schoenfeld 2010-01-09 19:14:37 UTC 
Review of attachment 150479 [details] [review]:

Committed.  Thanks!