GNOME Bugzilla – Bug 604770
Update introspection build
Last modified: 2009-12-28 02:24:32 UTC
These patches updates the build integration with the m4 macro and Makefile from introspection. Also bumps the required g-i version to 0.6.7 and makes sure the girs are included in the tarball.
Created attachment 149869 [details] [review] Use m4 macro to check for introspection
Created attachment 149870 [details] [review] Pass in --enable-introspection to distcheck
Created attachment 149871 [details] [review] Use Makefile.introspection To simplify the introspection scanner/compiler build rules. This also changes to the girs are included in the dist.
Created attachment 149872 [details] [review] Use m4 macro to check for introspection This patch includes the .m4 file and make sure it's disted
*** Bug 596506 has been marked as a duplicate of this bug. ***
*** Bug 594199 has been marked as a duplicate of this bug. ***
(In reply to comment #4) > Created an attachment (id=149872) [details] [review] > Use m4 macro to check for introspection > > This patch includes the .m4 file and make sure it's disted Distcheck probably fails with introspection unless $(addprefix $(srcdir)/,..) is called on all introspection _FILES.
1. I don't like including m4 in tree. Just check that introspection m4 is available during autogen.sh. 2. Commit if and only if make distcheck passes with fedora 12'ish. Thanks.
Created attachment 149976 [details] [review] Use Makefile.introspection To simplify the introspection scanner/compiler build rules. This also changes to the girs are included in the dist. This version also passes distcheck including a build where srcdir != builddir
The following fixes have been pushed: fd15a3a Use introspection.m4 f9adbd0 Use Makefile.introspection aad6150 Pass in --enable-introspection to distcheck
Created attachment 149981 [details] [review] Use introspection.m4 Use introspection.m4 without requiring it to be included in the tree.
Created attachment 149982 [details] [review] Use Makefile.introspection To simplify the introspection scanner/compiler build rules. This also changes to the girs are included in the dist.
Created attachment 149983 [details] [review] Pass in --enable-introspection to distcheck
As far as I can see there is now no way to compile Pango without having gobject-introspection installed? Is that right? Shoudn't this be optional like in other GNOME modules?
Created attachment 150227 [details] [review] Make GOBJECT_INTROSPECTION optional in autogen.sh Use the same machinery as the one used for AM_SILENT_RULES: m4_ifdef(). This allows people on old distros (Karmic) or other OS'es to compile without scary errors from autogen.sh.
(In reply to comment #15) > Created an attachment (id=150227) [details] [review] > Make GOBJECT_INTROSPECTION optional in autogen.sh > > Use the same machinery as the one used for AM_SILENT_RULES: m4_ifdef(). > This allows people on old distros (Karmic) or other OS'es to compile > without scary errors from autogen.sh. While I understand why you suggest this, it's not the right thing to do long term. I probably do it next time I have to make a release though...